fix(konnect): fix controlPlaneKonnectNamespacedRefAsSlice not enqueueing when konnectNamespacedRef has empty namespace
#688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing when konnectNamespacedRef has empty namespace
pmalek
force-pushed
the
fix-controlPlaneKonnectNamespacedRefAsSlice
branch
from
7fc93fe
to
2c1aabb
Compare
czeslavo
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes an issue with
controlPlaneKonnectNamespacedRefAsSlicewhen konnectNamespacedRef has no namespace specified.The fix uses the entity namespace and does not allow cross namespace references which will be implemented in Kong/kubernetes-configuration#36