Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add look up tags #1097

Closed
wants to merge 24 commits into from
Closed

Feat/add look up tags #1097

wants to merge 24 commits into from

Conversation

AntoineJac
Copy link
Collaborator

Description:
Please see Jira: https://konghq.atlassian.net/browse/APIOPS-100

This branch will add a new feature to pass a new lookup_tags in the _info section. It will allow the local state to retrieve the the corresponding entities in Kong.

_info: 
  lookup_tags:
    consumers:
    - test
    - test3
    - test2

@AntoineJac AntoineJac requested a review from a team November 9, 2023 07:25
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (df4a91d) 32.89% compared to head (f116584) 32.78%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1097      +/-   ##
==========================================
- Coverage   32.89%   32.78%   -0.12%     
==========================================
  Files         103      103              
  Lines       12839    12907      +68     
==========================================
+ Hits         4223     4231       +8     
- Misses       8207     8265      +58     
- Partials      409      411       +2     
Files Coverage Δ
file/types.go 56.13% <ø> (ø)
file/reader.go 59.49% <0.00%> (-2.35%) ⬇️
file/builder.go 47.57% <69.23%> (+0.23%) ⬆️
cmd/gateway_validate.go 0.00% <0.00%> (ø)
dump/dump.go 1.41% <0.00%> (-0.04%) ⬇️
cmd/common.go 3.73% <0.00%> (-0.25%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntoineJac AntoineJac mentioned this pull request Nov 9, 2023
@GGabriele GGabriele force-pushed the feat/add-look-up-tags branch 4 times, most recently from e66a3fa to 9e997be Compare November 9, 2023 12:23
@GGabriele GGabriele force-pushed the feat/add-look-up-tags branch from 9e997be to d82a097 Compare November 9, 2023 13:04
@AntoineJac
Copy link
Collaborator Author

Close as it has been refactoring here: #1124

@AntoineJac AntoineJac closed this Dec 18, 2023
@GGabriele GGabriele deleted the feat/add-look-up-tags branch January 15, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants