Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve security issue by using strconv.Atoi without upper/lower bounds #54

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

juancwu
Copy link
Contributor

@juancwu juancwu commented Nov 27, 2024

closes #53

test won't pass since they were broken and is outside of the issue scope. This PR fixes the test #55

@juancwu juancwu added the bug Something isn't working label Nov 27, 2024
@juancwu juancwu self-assigned this Nov 27, 2024
@juancwu juancwu linked an issue Nov 27, 2024 that may be closed by this pull request
1 task
Copy link
Member

@AmirAgassi AmirAgassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juancwu juancwu merged commit ba42f17 into main Nov 28, 2024
3 of 4 checks passed
@juancwu juancwu deleted the fix/53/inproper-strconv-atoi branch November 28, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Incorrect conversion between integer types
2 participants