Add project form questions #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juancwu
added
enhancement
4 tasks
add some questions and alter the project_questions table to be more robust
notion questions updated
the enum for input type was removed because the option to include multiple inputs, such as url or file(s)
juancwu
force-pushed
the
feat/189/seed-db-with-questions
branch
from
2c5145a to
b94ba9d
Compare
AmirAgassi
requested changes
Jan 12, 2025
the tests relied on the questions added by migration files which makes this method not reliable. The migration questions change all the time so it's better to remove the migrated questions and seed sample questions for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the questions from Notion have been added.
Explanation of new columns added to the
project_questionstable.sub_section_orderis the order for the questions to be rendered inside a sub section.input_typeis not an enum because of the need to allow multiple types for one question. Such as allowing users to input a URL to a google drive with documents or just uploading files. So having a varchar which allows the syntaxA|Bwould make more sense and it would be more flexible.optionsis a nullable column which contains the options for input typesselect,checkbox,radio.Possible improvements is to store the order of sections too and these can be in a separate table or just defined in the frontend.
Linked Issues
Testing
Checklist
Before opening this PR, make sure the PR:
Additionally, make sure that: