Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-email verification view #298

Merged
merged 6 commits into from
Dec 28, 2024
Merged

Conversation

juancwu
Copy link
Contributor

@juancwu juancwu commented Dec 27, 2024

Description

Add a view for the different states after a user clicks on the link to verify their email. This view has three different modes:

  1. Success
  2. Failure
  3. Internal Error

The view has also been added to the route handler so that it renders the view instead of responding with a JSON.

Linked Issues

Testing

  • Tests for the /api/v1/auth/verify-email route in tests/server_test.go have been updated to expect the route to render the view instead of JSON response.

Screenshots

Screenshot From 2024-12-26 20-32-31

Screenshot From 2024-12-26 20-54-23

Screenshot From 2024-12-26 20-32-16

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@juancwu juancwu added enhancement New feature or request backend Related to the backend of the project api Related to the backend routes and endpoints labels Dec 27, 2024
@juancwu juancwu added this to the Complete the project MVP milestone Dec 27, 2024
@juancwu juancwu self-assigned this Dec 27, 2024
@juancwu juancwu linked an issue Dec 27, 2024 that may be closed by this pull request
7 tasks
@SherRao SherRao changed the title Post Email Verification View Add post-email verification view Dec 27, 2024
@juancwu juancwu marked this pull request as ready for review December 27, 2024 23:44
Copy link
Member

@AmirAgassi AmirAgassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juancwu juancwu merged commit 436829a into main Dec 28, 2024
4 checks passed
@juancwu juancwu deleted the feat/213/email-verification-views branch December 28, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the backend routes and endpoints backend Related to the backend of the project enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BE Feat] Create verification email redirect views
2 participants