Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add register auth route #280

Merged
merged 26 commits into from
Dec 23, 2024
Merged

Add register auth route #280

merged 26 commits into from
Dec 23, 2024

Conversation

juancwu
Copy link
Contributor

@juancwu juancwu commented Dec 21, 2024

Description

Route that handles user registration. This route is not complete. The PR a here to allow reviews to improve/change things that must be done during registration.

As of now, the request body validation is not done via a middleware but should be updated once it is merged.

The response body is just a generic map at the moment because the login route shares the same struct. For this reason, the response body should be updated to use the same one as the login route to save memory space.

More tests need to be added and will be added once the login route PR gets merged and also the validator middleware is merged.

Linked Issues

Testing

  • Tested the /api/v1/auth/register route that returns a 201 on success.

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@juancwu juancwu added the backend Related to the backend of the project label Dec 21, 2024
@juancwu juancwu added this to the Complete the project MVP milestone Dec 21, 2024
@juancwu juancwu self-assigned this Dec 21, 2024
@juancwu juancwu linked an issue Dec 21, 2024 that may be closed by this pull request
4 tasks
@juancwu juancwu changed the title Feat/180/register route Register route Dec 21, 2024
@SherRao SherRao changed the title Register route Create Register auth route Dec 21, 2024
@SherRao SherRao changed the title Create Register auth route Add register auth route Dec 21, 2024
@SherRao SherRao added api Related to the backend routes and endpoints enhancement New feature or request labels Dec 21, 2024
@juancwu juancwu force-pushed the feat/180/register-route branch from 4a86714 to 4d467ce Compare December 21, 2024 23:42
Copy link
Member

@AmirAgassi AmirAgassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juancwu juancwu merged commit 971716b into main Dec 23, 2024
4 checks passed
@juancwu juancwu deleted the feat/180/register-route branch December 23, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the backend routes and endpoints backend Related to the backend of the project enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BE Feat] Create Register authentication endpoint
4 participants