-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add register auth route #280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
SherRao
added
api
Related to the backend routes and endpoints
enhancement
New feature or request
labels
Dec 21, 2024
unify the usage of the same function so that the cookie is always the same config
juancwu
force-pushed
the
feat/180/register-route
branch
from
December 21, 2024 23:42
4a86714
to
4d467ce
Compare
AmirAgassi
reviewed
Dec 23, 2024
AmirAgassi
reviewed
Dec 23, 2024
aidantrabs
reviewed
Dec 23, 2024
aidantrabs
reviewed
Dec 23, 2024
AmirAgassi
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Related to the backend routes and endpoints
backend
Related to the backend of the project
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Route that handles user registration. This route is not complete. The PR a here to allow reviews to improve/change things that must be done during registration.
As of now, the request body validation is not done via a middleware but should be updated once it is merged.
The response body is just a generic map at the moment because the login route shares the same struct. For this reason, the response body should be updated to use the same one as the login route to save memory space.
More tests need to be added and will be added once the login route PR gets merged and also the validator middleware is merged.
Linked Issues
Testing
/api/v1/auth/register
route that returns a 201 on success.Checklist
Before opening this PR, make sure the PR:
Additionally, make sure that: