Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registration Page #28

Merged
merged 20 commits into from
Nov 20, 2024
Merged

Registration Page #28

merged 20 commits into from
Nov 20, 2024

Conversation

aidantrabs
Copy link
Member

@aidantrabs aidantrabs commented Nov 17, 2024 •
edited
Loading

@aidantrabs aidantrabs added the enhancement New feature or request label Nov 17, 2024
@aidantrabs aidantrabs requested a review from juancwu November 17, 2024 05:04
@aidantrabs aidantrabs self-assigned this Nov 17, 2024
@aidantrabs
Copy link
Member Author

have a very basic iteration of the register wallet pages @juancwu @AmirAgassi

  • will need to update once backend is integrated
  • also need to update the textinput + textarea for correct error formatting

AmirAgassi
AmirAgassi approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@AmirAgassi AmirAgassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I lowkey think TextInput/TextArea's labels look better without bold

src/components/TextInput.tsx Outdated Show resolved Hide resolved
src/components/TextArea.tsx Outdated Show resolved Hide resolved
@aidantrabs aidantrabs merged commit a9c6864 into main Nov 20, 2024
1 check passed
@juancwu juancwu deleted the feat/23/register-wallet branch November 22, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancwu juancwu juancwu left review comments

@AmirAgassi AmirAgassi AmirAgassi approved these changes

Assignees

@aidantrabs aidantrabs

Labels
enhancement New feature or request
Projects
SPUR Platform
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE: Register Wallet 2A
3 participants
@aidantrabs @AmirAgassi @juancwu