Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/217/v1 commons #229

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Feat/217/v1 commons #229

merged 5 commits into from
Dec 18, 2024

Conversation

juancwu
Copy link
Contributor

@juancwu juancwu commented Dec 17, 2024

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Description

  • Since we don't have much right now in the backend, just some basic response structs were made.
  • A new file was also introduced to put request structs for the v1 package routes.
  • Two helpers functions added to help with responding repetitive code branches.

Linked Issues

Type of Change

Please delete options that are not relevant:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Testing

  • Test success helper cases: with message, and without message
  • Test fail helper cases: with/without message and with/without internal error

@juancwu juancwu added enhancement New feature or request backend Related to the backend of the project labels Dec 17, 2024
@juancwu juancwu added this to the Complete the project MVP milestone Dec 17, 2024
@juancwu juancwu self-assigned this Dec 17, 2024
@juancwu juancwu linked an issue Dec 17, 2024 that may be closed by this pull request
9 tasks
Copy link
Member

@AmirAgassi AmirAgassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juancwu juancwu merged commit 59215a8 into main Dec 18, 2024
4 checks passed
@juancwu juancwu deleted the feat/217/v1-commons branch December 18, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the backend of the project enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BE Feat] Setup and create common shared data structures and objects
2 participants