Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check #178

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Health check #178

merged 14 commits into from
Dec 16, 2024

Conversation

juancwu
Copy link
Contributor

@juancwu juancwu commented Dec 16, 2024

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Description

Add a health check route. There are some other files changes to allow the app the run since everything is broken right now.

Linked Issues

  • Got PR before issue so 🤷

Type of Change

  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Testing

  • internal/v1/v1_health/healthcheck_test.go tests internal methods that gather health information
  • internal/tests/server_test.go blackbox testing of the health check route

@juancwu juancwu added the backend Related to the backend of the project label Dec 16, 2024
@juancwu juancwu added this to the Complete the project MVP milestone Dec 16, 2024
@juancwu juancwu self-assigned this Dec 16, 2024
@juancwu juancwu merged commit 704dbdd into main Dec 16, 2024
4 checks passed
@juancwu juancwu deleted the health-check branch December 16, 2024 21:08
@SherRao SherRao linked an issue Dec 16, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the backend of the project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BE Feat] Create health check route
3 participants