Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #74

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add tests #74

merged 1 commit into from
Nov 22, 2024

Conversation

AmirAgassi
Copy link
Member

will edit desc in later

@AmirAgassi AmirAgassi self-assigned this Nov 21, 2024
Copy link

Test Results ✅

Status: success
Coverage: 29.1%
OS: Linux

Test Details
  • Triggered by: @AmirAgassi
  • Commit: 61b6dfd
  • Branch: refs/pull/74/merge
  • Workflow: Run Tests

Copy link
Contributor

@juancwu juancwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Comment on lines +16 to +22
// setup test environment
os.Setenv("DB_HOST", "localhost")
os.Setenv("DB_PORT", "5432")
os.Setenv("DB_USER", "postgres")
os.Setenv("DB_PASSWORD", "postgres")
os.Setenv("DB_NAME", "postgres")
os.Setenv("DB_SSLMODE", "disable")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make a helper function to skip this repetitive setup...

@juancwu juancwu merged commit 317bc72 into main Nov 22, 2024
1 check passed
@juancwu juancwu deleted the 28-be-create-tests-for-all-api-calls branch November 22, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BE: Create tests for all API calls
2 participants