Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/64/user role enum #70

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Feat/64/user role enum #70

merged 6 commits into from
Nov 18, 2024

Conversation

juancwu
Copy link
Contributor

@juancwu juancwu commented Nov 17, 2024

Make changes to have a user role enum in db for better indexing performance
Add a validator tag to validate user roles, 1 to 1 with db enum values

this allows us to validate incoming request with user role
makes it more flexible as we change user role or have a 1:1 user role
values with the database
@juancwu juancwu added the enhancement New feature or request label Nov 17, 2024
@juancwu juancwu requested a review from AmirAgassi November 17, 2024 19:24
@juancwu juancwu self-assigned this Nov 17, 2024
Copy link

github-actions bot commented Nov 17, 2024

Test Results ✅

Status: success
Coverage: 14.9%
OS: Linux

Test Details
  • Triggered by: @juancwu
  • Commit: 12c4e60
  • Branch: refs/pull/70/merge
  • Workflow: Run Tests

sqlc.yml Outdated Show resolved Hide resolved
@juancwu juancwu merged commit 525efb4 into main Nov 18, 2024
1 check passed
@juancwu juancwu deleted the feat/64/user-role-enum branch November 18, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

BE: Create enum for user roles
2 participants