Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another dev/UI feedback #32

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

fabianschu
Copy link
Contributor

Description

Please include a summary of the change and if relevant which issue is fixed. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
regenerative-fi-ui ❌ Failed (Inspect) Jan 30, 2024 2:13pm

Copy link
Contributor Author

@fabianschu fabianschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  1. I don't know why Github doesn't show it on the PR page, but actually the build step of the CI failed => needs to be fixed, i believe the problem is this commit 1e7cf80
image
  1. when this problem has been solved, I believe there will be another problem that causes the CI to fail, namely the chunksize of the dashboard page => This likely also needs to be fixed. I believe the root cause is either a) the size of the animation file, or b) the size of lottie as dependency itself.

[screenshots are from other build runs]
Screenshot 2024-01-30 at 21 47 46
Screenshot 2024-01-30 at 21 48 54

@Another-DevX Another-DevX merged commit 9a6425d into fix/develop-build-error Jan 30, 2024
7 of 8 checks passed
@Another-DevX Another-DevX deleted the AnotherDev/UI-Feedback branch February 1, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants