Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another dev/add pools header #30

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Conversation

Another-DevX
Copy link
Member

Description

Please include a summary of the change and if relevant which issue is fixed. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

image

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

Copy link

vercel bot commented Jan 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
regenerative-fi-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 3:53pm

Copy link
Contributor

@fabianschu fabianschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you figured out why the subgraph can return multiple balancer entities? Formulated differently: it's not completely obvious for me why the subgraph returns an array here and under what conditions the array would contain more than one object. Do you have a suspicion here?

"balancers": [
      {
        "totalSwapVolume": "36.71838041831020998580002435787249",
        "totalLiquidity": "92.16052599111439610843035298991631",
        "id": "2",
        "poolCount": 5
      }
    ]

@fabianschu
Copy link
Contributor

fabianschu commented Jan 29, 2024

image

The Vercel build fails and test/lint CI are funky

@Another-DevX Another-DevX merged commit ab81241 into develop Jan 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants