Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another dev/UI feedback #22

Merged
merged 11 commits into from
Jan 22, 2024
Merged

Another dev/UI feedback #22

merged 11 commits into from
Jan 22, 2024

Conversation

Another-DevX
Copy link
Member

Description

Solve UI reviews issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

Please provide any relevant visual context for UI changes or additions. This could be static screenshots or a loom screencast.

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

Copy link

vercel bot commented Jan 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
regenerative-fi-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 4:51am

@fabianschu fabianschu force-pushed the AnotherDev/UI-feedback branch from 6add0d4 to 1ddd5d1 Compare January 22, 2024 04:20
@fabianschu
Copy link
Contributor

Fixed the merge conflicts for you with a rebase

Copy link
Contributor

@fabianschu fabianschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two typos, otherwise looks good to me!

@fabianschu fabianschu merged commit 2eb8447 into develop Jan 22, 2024
5 checks passed
@Another-DevX Another-DevX deleted the AnotherDev/UI-feedback branch January 25, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants