Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DarkMode Button #19

Closed
wants to merge 1 commit into from

Conversation

Another-DevX
Copy link
Member

Description

Include DarkMode button to improve the UX about the DApp

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

image image image

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

Copy link

vercel bot commented Jan 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
regenerative-fi-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 7:02pm

Copy link
Contributor

@fabianschu fabianschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch doesn't seem to include the latest changes, e.g. it doesn't use @kolektivo-labs/sdk, but @balancer-labs/sdk. Therefore I get a bunch of errors when running the app. Example:

image

@Another-DevX
Copy link
Member Author

This branch doesn't seem to include the latest changes, e.g. it doesn't use @kolektivo-labs/sdk, but @balancer-labs/sdk. Therefore I get a bunch of errors when running the app. Example:

image
image I'm pretty confussed

@Another-DevX
Copy link
Member Author

This branch doesn't seem to include the latest changes, e.g. it doesn't use @kolektivo-labs/sdk, but @balancer-labs/sdk. Therefore I get a bunch of errors when running the app. Example:
image

image I'm pretty confussed

image Pls remove the branch a reclone it

@fabianschu
Copy link
Contributor

I rebased the branch on develop which seems to have solved the dependency issue (before I did that the last commit had been from last month?). The project runs, but I don't see the button.

@Another-DevX
Copy link
Member Author

I'll drop this PR and add the darkModeButton at the UI review

@Another-DevX Another-DevX deleted the AnotherDev/Create-dark-mode-button branch February 1, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants