Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liquidity table to dashboard #18

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

Another-DevX
Copy link
Member

Description

Implement User's liquidity at dashboard view

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Visual context

image

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas
  • If package-lock.json has changes, it was intentional.
  • The base of this PR is master if hotfix, develop if not

@Another-DevX
Copy link
Member Author

The implementation works except for Celo Alfajores, but I am confident that the issue is not with the client but with the subgraph, as Optimism, for example, works perfectly.

@Another-DevX
Copy link
Member Author

Another-DevX commented Jan 18, 2024

The implementation works except for Celo Alfajores, but I am confident that the issue is not with the client but with the subgraph, as Optimism, for example, works perfectly.

image
I find the error, we don't have an uri pointed to any subgraph with gauges data

Copy link
Contributor

@fabianschu fabianschu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
regenerative-fi-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 3:52pm

@Another-DevX Another-DevX merged commit 949559f into develop Jan 19, 2024
5 checks passed
@Another-DevX Another-DevX deleted the AnotherDev/display_liquidity_on_dashboard branch February 1, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants