-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How is Upheno being used in KG-Phenio? #40
Comments
Thanks Harry for the detective work! It seems like the reason Luca is observing that topology of kg-phenio isn't helping with HP-MP link prediction is that we are not merging Upheno data into the merged kg-phenio graph. Maybe Sierra or others on the KGX team can help us understand why? |
I'm not sure it's all in the original
i.e., we expect to see more A sameAs UPHENO sameAs B but there just aren't that many distinct UPHENO classes imported to begin with. |
@caufieldjh thanks! I just discussed this briefly with Chris, and we think what might be called for here is adding some functionality to KGX to preserve subq phenotype patterns when converting OWL to KGX. We can hack on this tomorrow on the NEAT call from 9:30 - 10:00 am PT to make a PR for KGX to support this. |
Integration test:
I think 2 will work just fine. For 1 ideally these edges would be supplied upstream but in the absence of this I think a procedural transform in kgx or oak is best. |
I think adding code to KGX has great potential for confusion; It is not at all easy to extract the relationships correctly from subq, unless you do something trivial like creating associative edges with no semantics based on the signature of the EQ ("if limb is mentioned, its associated"). The better way would be to apply some pressure on this pull request: mgijax/mammalian-phenotype-ontology#3480 Once we can convince @sbello to add this, we can convince all the other phenotype ontologies, and once it is in all phenotype ontologies apart from HP, we can get try to get it into HP. If we cant get it into HP, we can still add a release artefact that is hp.owl + relations, published by hp, to cater such cases. |
How does Upheno relate to our target MP and HP phenotypes? How may it help to connect them (and hence give our models a way to learn connections between them)?
We currently have a set of Upheno gold-standards and they all kind of look like this:
but these are not included in the merge.
The input monarch-merged.owl imports and frequently mentions Upheno:
Many of these are in axioms with Uberon:
In the KGX transform, we have just a few UPHENO types:
and not many edges:
Same_as predicates connecting HP and MP may not use Upheno:
Another example:
So should we expect to see more paths between HP and MP nodes c/o Upheno and KGX is just ignoring them, or is this the best we can get?
The text was updated successfully, but these errors were encountered: