-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto submodules, auto workspaces, build on install; support standard build call #87
Conversation
…tomatically, and build once on install. Also, stub the standard build call to point to project build. Currently untested due to KnodesCommunity#82
} ); | ||
const out = testHost.mapPagesToReflections( [ { title: 'HIDDEN', source: 'foo.md' } ] ); | ||
expect( out ).toHaveLength( 1 ); | ||
} ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this test extremely suspect, and I doubt it
I have trouble understanding your structure because I'm not clear on what a "reflection" is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A refkection is none of my concept : it's directly inherited from typedoc structure, which is a pain in the a**.
Basically any objects in your project, frol the project itself, to const, symboks, type defs, & anything that is output to the docs is a reflection.
return node.children ? | ||
this._mapPagesToReflections( node.children, parent, childrenIO ) : | ||
[]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm genuinely not clear on whether this actually works. Once building works again, I'll go kick it until it plays nice
I accidentally presented more in this PR than I had meant to; this should be two PRs. Sorry; I botched remaking them after --no-verify Sending anew, momentarily |
This is what I had meant to send. #88 |
This is the extra part that I accidentally stacked in. It needs to be distinct because that part isn't yet ready. #89 |
On install, attempt to:
Also, stub the standard build call to point to project build.
Currently untested due to #82