Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit checks for null and undefined in unwrappedData.sort #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added explicit checks for null and undefined in unwrappedData.sort #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions koGrid-2.1.1.debug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2123,9 +2123,9 @@ window.kg.sortService = {
// we want to force nulls and such to the bottom when we sort... which effectively is "greater than"
if (!propB && !propA) {
return 0;
} else if (!propA) {
} else if (!propA && (propA === undefined || propA === null)) {
return 1;
} else if (!propB) {
} else if (!propB && (propB === undefined || propA === null)) {
return -1;
}
//made it this far, we don't have to worry about null & undefined
Expand Down
2 changes: 1 addition & 1 deletion koGrid-2.1.1.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.