Modernize setuptools support to use pyproject.toml #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the obsolete `setup.py` script and `setup.cfg` configuration file with the modern PEP 621 `pyproject.toml` metadata. This also implies replacing the custom version/long-description grabbing logic (that is broken with Python 3.12) with the features nowadays built-in in setuptools. Fixes Knio#172
|
Thanks! but can you try to get the remaining CI passing? I give up for now. |
|
I can fix 3.12 but FWICS testing against 2.7 is no longer possible with GHA. |
mgorny
force-pushed
the
pyproj-tom
branch
2 times, most recently
from
58a6c82 to
d4a400a
Compare
|
Ok, I think that's as far as we can reasonably get. Python < 3.7 is no longer supported by setuptools even. |
|
Thanks, this seems to work in CI, but I can't actually build a package locally to publish, as it just makes "UNKNOWN" $ python3 -m build --no-isolation
* Getting build dependencies for sdist...
running egg_info
writing UNKNOWN.egg-info/PKG-INFO
writing dependency_links to UNKNOWN.egg-info/dependency_links.txt
writing top-level names to UNKNOWN.egg-info/top_level.txt
reading manifest file 'UNKNOWN.egg-info/SOURCES.txt
...etcany ideas? $ python3 --version
Python 3.9.2
$ python3 -m build --version
build 1.0.3 (/usr/local/lib/python3.9/dist-packages/build) |
|
Thanks! |
|
Thanks for the PR, any chance cutting off a new release? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the obsolete
setup.pyscript andsetup.cfgconfiguration file with the modern PEP 621pyproject.tomlmetadata. This also implies replacing the custom version/long-description grabbing logic (that is broken with Python 3.12) with the features nowadays built-in in setuptools.Fixes #172