Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sgp40: Add sgp40 support #6738

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

meteyou
Copy link
Contributor

@meteyou meteyou commented Nov 13, 2024

Add support for the SGP40 Sensor for VOC mesurement. This sensor needs a temp + huminity sensor to work correct. If you don't add one, it will use 25°C and 50% huminity as reference.

Here is an example config:

[temperature_sensor BME_OUT]
sensor_type: BME280
i2c_address: 118
i2c_mcu: pico
i2c_bus: i2c1e
i2c_speed: 400000

[temperature_sensor SGP_OUT]
sensor_type: SGP40
i2c_mcu: pico
i2c_bus: i2c1e
ref_temp_sensor: bme280 BME_OUT
ref_humidity_sensor: bme280 BME_OUT

Link to discourse: https://klipper.discourse.group/t/support-for-sgp40-sensors/20033

Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@@ -9,3 +9,4 @@ greenlet==3.0.3 ; python_version >= '3.12'
Jinja2==2.11.3
python-can==3.3.4
markupsafe==1.1.1
sensirion-gas-index-algorithm==3.2.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this library requires at least python 3.61, but klipper is still testing against python 2. I'm sure this is intentional, but I'm not sure why. It went end of life years ago2.

Footnotes

  1. https://pypi.org/project/sensirion-gas-index-algorithm/

  2. https://www.python.org/doc/sunset-python-2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants