Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected path for printer.cfg #6736

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Corrected path for printer.cfg #6736

wants to merge 2 commits into from

Conversation

c15yi
Copy link

@c15yi c15yi commented Nov 12, 2024

Looks like the path for printer.cfg changed a while ago according to this forum post.

@JamesH1978
Copy link
Collaborator

Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

You also have a whitespace issue you need to clear up, so the build checks can pass.

Thanks
James

Signed-off-by: Christian Navolskyi <[email protected]>
Copy link
Collaborator

@JamesH1978 JamesH1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for signing off, please see my one comment.

James

named "printer.cfg" in the home directory of the pi user
(ie, /home/pi/printer.cfg).
named "printer.cfg" under `~/printer_data/config`
(ie, /home/pi/printer_data/config/printer.cfg).
Copy link
Collaborator

@JamesH1978 JamesH1978 Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to word it so that the user knows that pi may not be the username.

Something i should have implied the first time round really!

Thanks
James

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Pushed an update.

Signed-off-by: Christian Navolskyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants