-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly expand BL Touch explanation of Pin configuration #6724
base: master
Are you sure you want to change the base?
Conversation
Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks |
TBH, I'm not sure if this not rather increases the confusion. |
Stating why the pullup is needed might help people who found wrong examples in the internet for probe configuration. Signed-off-by: Patrick Gerken <[email protected]>
Added Signed off and follow the preferred format. |
Maybe I am an outlier. I was stuck by this for two nights, being new to klipper and having used the Probe successfully with Marlin. But I trust your judgement whether it reduces help requests by BLTouch users or adds confusion. Independent of that, I will create a PR for the Bigtreetech sample config. |
There is already an ignored Pull Request and at least 7 open issues regarding that PIN and at least mentioning Klipper. 19 Bugs when also looking for Marlin. Meh, I didn't know how BTT treats the support of their hardware. |
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Stating why the pullup is needed might help people who found wrong examples in the internet for probe configuration.