feat: highlight borders on hover fix #523

[SimonAM]

Fix #523

[vercel]

@SimonAM is attempting to deploy a commit to the Klimatbyrån Team on Vercel.

A member of the Team first needs to authorize it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
klimatkollen	❌ Failed (Inspect)		May 28, 2024 6:29pm

[elvbom]

Tack för PR:n! Tittar på denna nästa vecka, bra jobbat!

[LudwikJaniuk]

Here, too, you will need to rebase onto staging due to the recent force-push.

[LudwikJaniuk]

Looking at the changes live on my computer, I worry about performance. When mousing around on the page, the framerate decreased drastically. See this in the chrome profiler:

On the regular map, the framerate is generally not impacted:

Perhaps the resolution used for the borders here is too fine? Please make your own measurements to ensure the change doesn't reduce performance.

[SimonAM]

Perhaps your merge with staging failed? I see no performance issues.

[SimonAM]

Or more specifically: I see no difference compared to staging.

[LudwikJaniuk]

Hi! Thanks for merging staging. The staging merge and the performance were two separate issues.

If you're saying that the current code doesn't have the performance issues I described, I'll review it as soon as I can myself. It's possible it was a local problem on my end.

[LudwikJaniuk]

I tried again today, comparing this branch to staging, and can still see the significant difference in framerate when mousing over regions. If you can't reproduce that, maybe we could sync on Discord and discuss methodology?