Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid pushing default dog identifier to TOPO server. #1

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bitonality
Copy link
Contributor

@bitonality bitonality commented Jul 23, 2023

The following behavior was observed when using an Alpha 100 as the host GPS.

Issue:

  1. Add collar to host GPS by using the track code.
  2. Host GPS initiates packet communication using "Dog" as a placeholder name while waiting for the user to edit the text name of the collar on the host GPS device.
  3. Tracker console gracefully handles the collar name changing, but this leaves a hanging reference on the TOPO server to a "{Callsign}-Dog" that is no longer receiving updates from the tracker software once the user updates the collar name on the host GPS.

This change proposes that we internally track collars as usual, but we skip pushing to the TOPO endpoint if the identifier is default ("Dog").

@bitonality bitonality marked this pull request as draft July 24, 2023 18:14
@bitonality
Copy link
Contributor Author

bitonality commented Jul 24, 2023

Alternatively, we could swallow the entire packet, but that would require logic changes with the internal identifier map (negligible performance impact). Advantages of swallowing the packet would be parity between the logged tracker file and the TOPO server internal db (1:1 log entry:TOPO server update).

I might also try sniffing packets during the add-collar-by-code routine to see if there's some sort of state that can be captured that would indicate that the collar is added to the device, but is unnamed (seems iffy though).

@mcosand Let me know if this issue is important enough to warrant a PR.

@mcosand
Copy link
Contributor

mcosand commented Aug 1, 2023

I believe for the majority of users, their device setup is static while using this program. It may be unlikely, but I'd hate to filter out messages that the user was intending on seeing. For now, I'd rather see this in your private build, or behind a command line argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants