Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

Mention Templates in KLC G section #419

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

heitorPB
Copy link

initial work on #352

@evanshultz
Copy link
Contributor

evanshultz commented Jun 30, 2019

@heitorPB
Can you give us an update on this? It is ready for review?

Also, please fix the branch conflicts and, if this is ready, bump the version at https://github.com/KiCad/kicad-website/pull/419/files#diff-87d0795c9f659b7ebd57e1b84e1c2435 and https://github.com/KiCad/kicad-website/pull/419/files#diff-88635b43085423a1810bd36ac8b0bc17 to 3.0.21.

Thanks!

@heitorPB
Copy link
Author

heitorPB commented Jul 1, 2019

@evanshultz
This is just some initial changes to mention templates in the General terms. Any review is very welcome!

I will try to make some more concrete plans for the Template sections, but I can't promise it will be very soon. It will probably be in a Google Docs to be easier to change stuff and get critics.

@evanshultz
Copy link
Contributor

evanshultz commented Jul 1, 2019

@heitorPB
Sure. I'll try take a look later. Just trying to triage and marshal KLC changes to implementation.

Edit: Note that I would now anticipate this revision being 3.0.22 at the earliest.

@heitorPB
Copy link
Author

heitorPB commented Jul 9, 2019

I can rebase and change the revision version. Just tell me when ;)

@evanshultz
Copy link
Contributor

@heitorPB
Above I understood there was a lot of work to be done before this PR would be ready. Can you please let us know if you believe this is ready for any review/discussion. I didn't come back to this because I was unaware you felt this work was mature.

@heitorPB
Copy link
Author

@evanshultz
sorry, should have made it clear.
KLC does not mention templates anywhere, I think the General section should also apply for them. That's basically what this PR adds. In this sense, it's ready for discussion. Every feedback is very welcome!

#352 is a more complex task: a complete KLC section on templates. I'm kind of new to KiCad, don't know where to start it, but I'll try some day to write a draft about it.

@sethhillbrand
Copy link
Contributor

@heitorPB The KiCad project is in the process of moving to GitLab. This issue will be migrated if it remains open. Please create an account by clicking on the GitHub login icon at https://gitlab.com/users/sign_in#register-pane

After you create your account, this pull request will remain assigned to your username at GitLab. If you do not create an account, this pull request will remain open but it will be assigned to the KiCad Bot.

@heitorPB
Copy link
Author

heitorPB commented Dec 7, 2019

@sethhillbrand I already have an GitLab account, but it was not automatically detected. The mentions in the merge request page link to my profile, but the bot did not find me. My user name there is the same as here heitorPB

@sethhillbrand
Copy link
Contributor

@heitorPB Thank you for helping us work through these issues. Can you go to https://gitlab.com/profile/account and connect your GitHub account there?

@heitorPB
Copy link
Author

heitorPB commented Dec 9, 2019

@sethhillbrand just did that! I checked the merge request page and still does not link to my username. Is there anything else I need to do?

@sethhillbrand
Copy link
Contributor

@heitorPB I'll need to manually re-sync the Gitlab transfer for it to show up. As soon as I do this, I'll update the thread here. Thanks!

nickoe and others added 5 commits August 16, 2020 17:58
Adjust releases that have gone EOL to unsupported and add MacOS 10.15
Update system requirements

See merge request kicad/services/kicad-website!503
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants