Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Correction Power name on 40pin connector #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mimosa-oceanis
Copy link

The power name on the 40pin connector were wrong. Now it's corrected.

The power name on the 40pin connector were wrong. Now it's corrected.
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2020

CLA assistant check
All committers have signed the CLA.

@nickoe
Copy link
Contributor

nickoe commented Jun 28, 2020

@Mimosa-oceanis Hi, thank you very much for your contribution, but I just reviewed it and to me it does not look like the original template is wrong. There are two nets, the one from the hat connector and the nets on the other side of the hat protection and selection jumpers.

Please describe in more detail what you think is wrong any why.

@Mimosa-oceanis
Copy link
Author

Hi @nickoe
I thought the same as you until I start routing the board. On the PCB the connection is wrong. If you check the 40 pins power 5v-hat doesn’t connect to the 5V on top layer. And it was simpler to just change the name in the schematic. And other point that way it also reduce the confusion because the way it was before was a bit confusing.

Hope I was clear.

Best regards

@Mimosa-oceanis
Copy link
Author

So no push to master ?

@evanshultz
Copy link
Collaborator

@Mimosa-oceanis
Maybe you can share some images to clarity this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants