Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

NB-IoT SIM7020 #748

Merged
merged 2 commits into from
Dec 30, 2018
Merged

NB-IoT SIM7020 #748

merged 2 commits into from
Dec 30, 2018

Conversation

jneiva08
Copy link
Contributor

@jneiva08 jneiva08 commented Jul 9, 2018

The symbol was created from symbol SIM800C and footprint is the same.

Datasheet: https://simcom.ee/documents/SIM7020/SIM7020%20Hardware%20Design_V1.01.pdf

Symbol:
nb-iot


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@antoniovazquezblanco antoniovazquezblanco added Pending reviewer A pull request waiting for a reviewer Addition Adds new symbols to library labels Oct 5, 2018
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Dec 12, 2018

Hi @jneiva08, thanks for contributing,

A few comments I have during my review:

  • I have not found a datasheet instead of the hardware design guide, have you got a link ?
  • According to the hardware design doc, pin 25 should be called USB_DN instead of USB_DM
  • I will say pin ANT is Bidirectional.

Cheers,
Joel

@antoniovazquezblanco antoniovazquezblanco added this to the Backlog milestone Dec 12, 2018
@jneiva08
Copy link
Contributor Author

It is the only datasheet can be found.
In the figure 2 of hardware design, you can found USB_DM and the table 3 you can find USB_DN. SIMCOM have made the same inconsistency on SIM800C, in that link can find why ANT is passive and not Bidirectional.

@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Dec 13, 2018

Hi @jneiva08

It is the only datasheet can be found.

Me too.

In the figure 2 of hardware design, you can found USB_DM and the table 3 you can find USB_DN. SIMCOM have made the same inconsistency on SIM800C

Good point, that's good to keep library consistent so USB_DM accepted.

in that link can find why ANT is passive and not Bidirectional.

Right. I do not know what is the Kicad strategy about that, if you look at several symbol in the lib, you can find Passive, Bidirectionnal, Input and Output antennas. According to me Passive is only for NC pins. @antoniovazquezblanco what is your advice ?

Cheers,
Joel

PS : once decision is made or I you have time right know, @jneiva08 can you fix branch conflict so it will be ready to be merged ? Thanks.

@antoniovazquezblanco
Copy link
Collaborator

Fixed merge conflicts caused by other PRs merge.

Right. I do not know what is the Kicad strategy about that, if you look at several symbol in the lib, you can find Passive, Bidirectionnal, Input and Output antennas. According to me Passive is only for NC pins. @antoniovazquezblanco what is your advice ?

We need help from one of the more experienced librarians here. @poeschlr, @evanshultz ?

Thanks!

@jneiva08
Copy link
Contributor Author

This answer of evanshultz from other gsm modem PR can help?

#634 (comment)

@poeschlr
Copy link
Collaborator

poeschlr commented Dec 13, 2018

NC (not connected) pins should not have type passive but type not connected.

I think antenna interface pins can be seen as input, output or even bidirectional. (depending on if your part is a receiver, transmitter or both.) The antenna it self however would be passive i think. Unless it is an active antenna.

Edit: added a bit of clarification

@myfreescalewebpage
Copy link
Collaborator

@jneiva08 I think the reason is not valid, we do not only use passive components on the ANT pins. Sometimes there are some amplifiers, RF switches, etc etc and of course there are active antennas.

I prefer the response of @poeschlr . Typically GPS ANT is input (can eb discussed because it also power the antenna itself throw the RF line), 433MHz transmitter ANT is output, GSM / LPWAN etc etc are Bidirectional. Some devices can transmit lots of power on output ANT.

@poeschlr which good use of Passive pin ? If you have an example ?

Cheers,
Joel

@jneiva08
Copy link
Contributor Author

I'm guessing the other reason to be passive, is because you normally need to add a matching impedance circuit, when you are making ERC validation it do now give a error/warning.

@poeschlr
Copy link
Collaborator

@myfreescalewebpage
I would say passive is for anything that does not really fit any of the other options. (sometimes also used for workarounds)

@jneiva08
Passive does not give you an error if you connect it to an input, output or bidirectional pin. So there is no danger in having false positives here.

@myfreescalewebpage
Copy link
Collaborator

@poeschlr since there is no clear KLC rules about antennas, I suggest @jneiva08 can keep its proposition to set it as Passive. When there is no guideline, submitter is the responsible of the commit, so he should keep the last word. Is it okay for you ? In any case this can be easily modified later if KLC are created on this subject.

@poeschlr
Copy link
Collaborator

We are working on a better way to give users guidance regarding pin types: KiCad/kicad-website#342

@myfreescalewebpage
Copy link
Collaborator

Any librarian, this PR is only blocked because of ANT pin type question. What should we do ?

@myfreescalewebpage myfreescalewebpage mentioned this pull request Dec 19, 2018
5 tasks
@myfreescalewebpage
Copy link
Collaborator

@poeschlr your position maybe ?

@myfreescalewebpage myfreescalewebpage self-assigned this Dec 23, 2018
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Dec 23, 2018
@poeschlr
Copy link
Collaborator

Looks good, thanks

@poeschlr poeschlr merged commit 5976e27 into KiCad:master Dec 30, 2018
@jneiva08 jneiva08 deleted the SIM7020 branch December 30, 2018 12:48
@jneiva08
Copy link
Contributor Author

thanks for all your time

@antoniovazquezblanco antoniovazquezblanco modified the milestones: Backlog, 5.1.0 Jan 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants