Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add SAM DA1 family #2687

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Add SAM DA1 family #2687

merged 2 commits into from
Jul 29, 2020

Conversation

jordiorlando
Copy link
Contributor

Add Microchip SAM DA1 family (everything except the chip-scale packages). Aliases of SAM D21 family from #2336, see screenshots/discussion from there.

Datasheet


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@jordiorlando jordiorlando mentioned this pull request May 1, 2020
6 tasks
@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels May 1, 2020
@cpresser cpresser self-assigned this May 9, 2020
@cpresser cpresser removed the Pending reviewer A pull request waiting for a reviewer label May 9, 2020
@cpresser
Copy link
Contributor

Hi and sorry for the huge delay.

I see you did add new symbols and not just aliases. That I don't understand (yet).
For example it seems to me that ATSAMDA1J14B-A and ATSAMD21J15A-A are identical and could use the alias feature.

@jordiorlando
Copy link
Contributor Author

@cpresser good question, I don't remember why I decided to do that. I think just aliases should be fine. I'll try to change that now.

@jordiorlando
Copy link
Contributor Author

@cpresser changed to be aliases

@cpresser
Copy link
Contributor

Looks good. Thanks!

@cpresser cpresser merged commit e30c25d into KiCad:master Jul 29, 2020
@jordiorlando jordiorlando deleted the SAMDA1 branch July 29, 2020 22:26
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.7 milestone Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants