Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Remove ATSAMD21G18A-AUT #2609

Merged
merged 8 commits into from
Sep 1, 2020
Merged

Conversation

aris-kimi
Copy link
Collaborator

Remove ATSAMD21G18A-AUT kept only -A

@aris-kimi
Copy link
Collaborator Author

@cpresser I saw this at the issues and did something. Tell me if we are good.

Thank you.

@myfreescalewebpage myfreescalewebpage added Enhancement Improves existing symbol in the library Pending reviewer A pull request waiting for a reviewer labels Apr 5, 2020
@cpresser cpresser added this to the 6.0.0 milestone Apr 5, 2020
@cpresser
Copy link
Contributor

cpresser commented Apr 5, 2020

Hi @aris-kimi
This PR looks okay. But It will have to wait for v6.0. The issue was a reminder for that.
I marked this PR so we can look at it again once we are nearing 6.0.

@aris-kimi
Copy link
Collaborator Author

Hi @cpresser, thank you for your answer. So this means the pull request will remain open until then right??

@cpresser
Copy link
Contributor

cpresser commented Apr 8, 2020

Correct.

@myfreescalewebpage
Copy link
Collaborator

Reference: #2563

@myfreescalewebpage myfreescalewebpage self-assigned this Apr 10, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Apr 10, 2020
@myfreescalewebpage
Copy link
Collaborator

No more comment, @cpresser is right, should be merged with V6.

@myfreescalewebpage myfreescalewebpage merged commit 740d9a5 into KiCad:master Sep 1, 2020
@aris-kimi aris-kimi deleted the remove_samd branch September 1, 2020 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing symbol in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants