Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Addition of LM3150 Buck Converter Controller #2572

Merged
merged 4 commits into from
Mar 31, 2020

Conversation

jamesrlucas
Copy link
Contributor

Addition of LM3150 Buck Converter Controller from Texas Instruments

Datasheet

I've laid the pins out in a manner that gives a clean schematic look - this is why ILIM & FB are on the right, depsite being inputs, and VCC is on the left. (See screenshot)
Are you happy with the footprint filter? Or should I make it more specific?

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Mar 24, 2020
@jamesrlucas
Copy link
Contributor Author

Is Travis on holiday or something?

@chschlue
Copy link
Contributor

Probably quarantined.

@cpresser cpresser self-assigned this Mar 27, 2020
@cpresser cpresser removed the Pending reviewer A pull request waiting for a reviewer label Mar 27, 2020
@cpresser
Copy link
Contributor

cpresser commented Mar 27, 2020

I like your pin-layout. Well though and even with an example how it can be wired up ❤️ .

Here is my review:

  • Pin names, numbers, types are good
  • package and fp-filter are good
  • Pin length must be 100mil (I wonder why travis does not detect that - perhaps we need a better test)
  • VIN can go onto the left side. Actually most voltage-regulators in the library are build that way and we like consistency. It does generate travis warning, but is okay. (We want to rework that anyway Improve S4.2 examples kicad-website#478). Then you can also put ENall the way to the top, then have VIN and with enough space to put a R_Small resistor the RONpin. Similar to point 4 in the data-sheet.
  • Please drop the word 'package' from the description, also 42-V should be 42V (without the dash)

- corrected Pin lengths
- updated package description
Changed name of Thermal pad to SGND to comply with KLC S4.3
@jamesrlucas
Copy link
Contributor Author

All done!

Travis didn't run when I previously submitted, so it didn't pick up the pin name offsets / lengths. All sorted now though.

@cpresser cpresser merged commit 34f7d20 into KiCad:master Mar 31, 2020
@cpresser cpresser added this to the 5.1.6 milestone Mar 31, 2020
jamesrlucas added a commit to jamesrlucas/kicad-symbols that referenced this pull request Apr 20, 2020
* Addition of LM3150 Buck Converter Controller

* Moved HG & BST pins for cleaner schematic

* - Rearranged pins
- corrected Pin lengths
- updated package description

* Fixed Pin Offset
Changed name of Thermal pad to SGND to comply with KLC S4.3
@jamesrlucas jamesrlucas deleted the add_lm3150 branch April 24, 2020 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants