Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Mounting Wuerth: Add all WA-SMSI M2.5 parts #2452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

myfreescalewebpage
Copy link
Collaborator

@myfreescalewebpage myfreescalewebpage commented Sep 5, 2020

Add all WA-SMSI M2.5 parts from https://www.we-online.com/catalog/en/SMSI_SMT_STEEL_SPACER_M2_5_THREAD_INTERNAL/ (the other sizes already exist)

Footprint PR: #2452
Footprint generator PR: pointhi/kicad-footprint-generator#608
Packages 3D PR: KiCad/kicad-packages3D#726
Packages 3D generator PR: easyw/kicad-3d-models-in-freecad#392

Image of the part from WE:
o92910v209 Family_WA-SMSI_M2-M2 5

Screenshot of footprint:
Capture

Screenshot of 3D package (pointhi/kicad-footprint-generator#608):
Capture


⚠️ Deprecation warning

On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by kicad-bot (importer documentation).


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Sep 5, 2020
@myfreescalewebpage
Copy link
Collaborator Author

PS 1 : I have notice all the other Mounting Wuerth in the kicad-footprints repo are not exactly the ones generated by the generator. I don't know if this is normal but I can push a new PR if required.

PS 2 : I see other WA-SMSI have a 3D package. Is it generated with a script and if yes where is it ? I can do it for the M2.5 parts too.

@chschlue
Copy link
Contributor

chschlue commented Sep 5, 2020

#1612
KiCad/kicad-packages3D#557
pointhi/kicad-footprint-generator#351
easyw/kicad-3d-models-in-freecad#284

I can only assume the current footprints were created using a previous script version (haven't checked in depth.)
@poeschlr

@myfreescalewebpage
Copy link
Collaborator Author

@chschlue thanks for the links! I will look to create the 3D corresponding to this PR now.
Strange that the footprint have not been updated if the script has been modified, isn't it ?
Here are the screenshots of the diff on 1 footprint. Not a lot of modifications, but some dimensions not match. Can be relevant for the review of this PR maybe:

Capture1
Capture2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants