Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Kailh Choc low profile kbd switch #2420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

perigoso
Copy link
Contributor

See #2416 and #2394

This PR Adds Kailh Choc low profile keyboard switch footprints.

@perigoso perigoso changed the title Added Kailh Choc low profile kbd switch Add Kailh Choc low profile kbd switch Aug 25, 2020
@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Aug 25, 2020
@ghost
Copy link

ghost commented Aug 26, 2020

I think I will start with those, since it is just 5 footprints.

So far all I could find for documentation were those pictures:
grafik

  • Is there more, better documentation?
  • Where are the pins located (x/y) coordinates? And the mechanical mounting holes?
  • According to KLC the footprint-origin needs to be on Pin1 for THT components. I am thinking about deviating from that rule. For a keyboard-designer the center of the keycap would be a better choice. @chschlue What do you think?
  • That 5.5x2.95 area, what is it?
  • What is the 1.00u thing in the name? Imho the name should be something like CPG135301. The library-name already has the manufacturers name and series.
  • The drill in the center is 4.8mm according to the drawing, but the footprint has 3.4mm?

@chschlue
Copy link
Contributor

  • According to KLC the footprint-origin needs to be on Pin1 for THT components. I am thinking about deviating from that rule. For a keyboard-designer the center of the keycap would be a better choice. @chschlue What do you think?

I'm not too familiar with the contemporary keyboard industry but I assume your typical off-the-shelf keyboard is not hand-assembled by wage slaves. Meaning if some sort of PnP origin is documented somewhere, that would solve the problem.
Other than that, I'm with you here.

@perigoso
Copy link
Contributor Author

perigoso commented Aug 26, 2020

Firstly I want to state that I did not originally create most of these footprints, and though i went through most of them and made some extensive modifications, I assumed the footprint was correctly made according to documentation in the first place.

I think they have already been tested in real life, so i did not actually check it though i probably should've anyway.

That being said I made an effort to try to find the documentation for review, which i posted in the first PR #2394 Reference for Kailh Choc keyswitches it comes from the official manufacturers site so assume it's the best we got, unless maybe we tried contacting them.

You found the documentation for the version 2 of these switches, this should explain some of the discrepancies.
image

  • According to KLC the footprint-origin needs to be on Pin1 for THT components.

Like I mentioned in the original PR this was intentional as I felt it made sense given the nature of these components.

  • That 5.5x2.95 area, what is it?

That is a cutout the component has that is meant for an LED to be mounted behind for retroilumination. this could be added to a documentation layer, but I don't find it necessary.

  • What is the 1.00u thing in the name? Imho the name should be something like CPG135301. The library-name already has the manufacturers name and series.

That is the dimension of the Keycap 1.00u in the keyboard world means 19.05mm this is standard nomenclature, the documentation layers have the keycap represented this is for layout and alignment purposes. such a specific label does not make sense in my eyes given that this footprint fits multiple references, and Kailh Choc is a unique series and is representative enough I feel.

@perigoso perigoso closed this Aug 26, 2020
@perigoso perigoso reopened this Aug 26, 2020
@perigoso
Copy link
Contributor Author

ups.

@perigoso perigoso force-pushed the kbd-fp-rework-kailh_Choc branch from 97f8e6a to 0b1fb68 Compare September 4, 2020 05:59
@perigoso
Copy link
Contributor Author

perigoso commented Sep 4, 2020

Generated footprints with kicad-footprint-generator.

image

@perigoso
Copy link
Contributor Author

perigoso commented Sep 4, 2020

datasheet

@cpresser
Copy link
Contributor

I added myself as reviewer. But I doubt I will be able to wrap this up before our move to gitlab. If somebody else wants to take this over, please go ahead.

Related: pointhi/kicad-footprint-generator#605

@cpresser cpresser self-assigned this Sep 10, 2020
@cpresser cpresser removed the Pending reviewer A pull request waiting for a reviewer label Sep 10, 2020
@perigoso perigoso force-pushed the kbd-fp-rework-kailh_Choc branch from 0b1fb68 to f24a55c Compare September 13, 2020 11:27
@perigoso
Copy link
Contributor Author

Re-generated footprints with kicad-footprint-generator after fixups.

@perigoso perigoso force-pushed the kbd-fp-rework-kailh_Choc branch from f24a55c to 45b63fc Compare September 13, 2020 11:33
@cpresser cpresser added the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Ready for review Use this to mark pull requests that are updated but you could not review instantly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants