Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

BGA-320 footpring for the Cologne Chip GateMate FPGA #2183

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ak-fau
Copy link

@ak-fau ak-fau commented Mar 28, 2020

BGA-320 footpring for the Cologne Chip GateMate FPGA
(18x18 matrix with 4 balls removed).

Matching symbol PR KiCad/kicad-symbols#2578

Datasheet

Footprint preview


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2020

CLA assistant check
All committers have signed the CLA.

@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Mar 29, 2020
@cpresser cpresser self-assigned this Aug 23, 2020
@cpresser cpresser added Scripting required A scripted version of this contribution is required and removed Pending reviewer A pull request waiting for a reviewer labels Aug 23, 2020
@cpresser
Copy link
Contributor

Thanks for you submission and sorry for the huge delay (we are rather constrained with our resources for reviews).

How did you create this footprint? Did you script it?
Anyway, we do require footprints that can easily be created with our official scripts to be done with them.
In this case head over to https://github.com/pointhi/kicad-footprint-generator/blob/master/scripts/Packages/Package_BGA/bga.yaml and add the BGA-320 footprint there.
The reasoning is that we trust the generator to work properly. And if something is wrong, we can easily recreate all packages (for example, someone decides that all the courtyard should be 0.5 instead of 1.0mm).
Please add a PR over at the generator repository and link it with this PR. I will review and merge both.

@ak-fau
Copy link
Author

ak-fau commented Sep 7, 2020

Hello.

Thanks for your submission and sorry for the huge delay (we are rather constrained with our resources for reviews).

My pleasure and no problem with the delay. Shortage of resources for reviews is well
understood and your efforts are highly appreciated.

How did you create this footprint? Did you script it?

Unfortunately, hand-edited from the similar one. Somehow it skipped my attention
that scripting is not just an alternative, but a preferable and recommended way.
I guess part of the confusion came from the fact that generators repo is not hosted
under an "official" kicad github account...

Anyway, we do require footprints that can easily be created with our official scripts to be done with them.

Understood and makes perfect sense.

In this case head over to https://github.com/pointhi/kicad-footprint-generator/blob/master/scripts/Packages/Package_BGA/bga.yaml and add the BGA-320 footprint there.
The reasoning is that we trust the generator to work properly. And if something is wrong, we can easily recreate all packages (for example, someone decides that all the courtyard should be 0.5 instead of 1.0mm).
Please add a PR over at the generator repository and link it with this PR. I will review and merge both.

Sorry, it took me some weeks to address that, I've been on vacations.
PR has been submitted a few hours ago.

Looking forward to receiving your comments.

Thanks.

…enerated with kicad-footprint-generator script.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Scripting required A scripted version of this contribution is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants