Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added DCC6C footprint for saw filters (like EPCOS) #1206

Closed
wants to merge 10 commits into from
Closed

Added DCC6C footprint for saw filters (like EPCOS) #1206

wants to merge 10 commits into from

Conversation

omogenot
Copy link

@omogenot omogenot commented Dec 22, 2018

DCC6C footprint for saw filters


Datasheet : https://en.rf360jv.com/inf/40/ds/ae/B3717.pdf
3D package under KiCad/kicad-packages3D#485
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@omogenot
Copy link
Author

Travis-Ci says that anchor is not in the middle, but I guess the test fails the test because pad1 is offset by 0.3 mm, which is not a common situation.

@poeschlr
Copy link
Collaborator

A screenshot of the footprint here in the pull request would help a lot.

@poeschlr poeschlr added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Dec 22, 2018
@omogenot
Copy link
Author

Here you go ....

dcc6c footprint

@aewallin
Copy link
Contributor

  • courtyard looks too close, should be 0.25mm margin to f.fab outline and pads(?)
  • can't see if there's a bevel on f.fab to indicate pin1
  • indicate pin1 on silk also

@omogenot
Copy link
Author

Don't you have a cue card (just a one page quick guide summary of list items) of requirements? That would be very helpful to limit the try/fail cycle (and the frustration associated with it I must admit).
I've been using Kicad for many years and designed these symbols at the time no Fab nor CYrd layers where existing and never had to design or used them.

@aewallin
Copy link
Contributor

F1 to F9 of KLC. Not sure if there is a summary/shorter version..
http://kicad-pcb.org/libraries/klc/

- Added Pin1 mark on Silk
- Moved out CYrd and Fab lines
@omogenot
Copy link
Author

New trial ;-)

dcc6c footprint

@omogenot
Copy link
Author

That's what I meant, having a one page (or even less) summarizing margins, line widths, sizes, etc... not all the details with pictures and so on, just as a reminder and helping doing a very quick checklist per layer.
By the way, but this is certainly another topic, why Kicad does not have default line widths, grid settings according to these requirements...

@aewallin
Copy link
Contributor

  • I agree that the footprint-editor should use default widhts/settings.
  • a "check KLC" button would also be very handy - it would report problems immediately
  • I don't know if the KLC can be shortened to one page, or if someone already made an effort to do this.

For your new screenshot check F5.1.3 "For SMD footprints, silkscreen must be fully visible after boards assembly (no silkscreen allowed under component)"
Maybe you can use this style to indicate pin1 on silk: https://user-images.githubusercontent.com/4781841/38120284-75f8bb9a-3413-11e8-98ce-87a61a77e9fb.png

sorry no review of geometry/dimensions by me yet..

@aewallin
Copy link
Contributor

The courtyard-tolerance is quite tight. It is probably best to use an automated tool for this.
maybe the "--fix" option from the library-utils: https://github.com/KiCad/kicad-library-utils

I also created my own courtyard-maker, because getting it right by hand is so frustrating:
https://gist.github.com/aewallin/a9b3d785c13584c0bac84e6099a8f5ed
(this may or may not be the same that "--fix" option does - I have not checked)

@omogenot
Copy link
Author

Well, definitely the silkscreen will still be visible after assembly. And the courtyard is probably larger enough looking at the resulting 3D view.

dcc6c 3d

Using the type of marker you suggested was resulting in getting questions from my factories. They don't like this type of marking and prefer dots or bevels.

@poeschlr
Copy link
Collaborator

The fab outline should represent the part body size not some framing around the pads.

@poeschlr
Copy link
Collaborator

The datasheet does not contain a suggested footprint. How did you determine the required pad sizes?

@omogenot
Copy link
Author

Just to illustrate what I was just saying (frustrating). Different grids for different layers. Difficult to remember them all (especially for an old man, close to retirement, like me)..

dcc6c footprint

@omogenot
Copy link
Author

The datasheet does not contain a suggested footprint. How did you determine the required pad sizes?

Google: DCC6C landing pattern ==>
http://52ebad10ee97eea25d5e-d7d40819259e7d3022d9ad53e3694148.r84.cf3.rackcdn.com/UK_ACT_ACT9401-866MHz-DCC6C-F866BMB_DS.pdf

I've been using successfully this footprint for production for the last 8 years.

@omogenot
Copy link
Author

The fab outline should represent the part body size not some framing around the pads.

So, we agree that the Fab layer would cross the pads?

@omogenot
Copy link
Author

dcc6c footprint

@poeschlr
Copy link
Collaborator

poeschlr commented Dec 23, 2018

Fab is not printed onto the pcb so there is no problem with crossing the pads.
The pin 1 chamfer should be 25% of the smallest body dimension or at most 0.25mm 1mm Edit: and it should be 45 degree (chamfer size equal in x and y direction)

You really should read the full KLC not just a summary it seems 😁

@poeschlr
Copy link
Collaborator

Regarding you being successful with this patter: Does not proof anything to be honest. I don't know which manufacturing methods you use. Others can not know anything about that. We therefore prefer the use of industry standards (IPC) or manufacturer suggestions (datasheet, application note).

Please link the actual document you used to design the footprint both in the pull request description and inside the footprint description.


@aewallin i think you hang yourself up on some things that are a bit strange. The courtyard layer is the only layer that has any tolerance allowance at all. The fab layer for example must be exact (0 tolerance) same with everything that has to do with pads (copper, mask and paste).
And the only reason there is tolerance is because IPC suggests the use of 0.01 grid for it.

The only other layer where we basically do not really care about measurements is the silk layer. (As long as the clearance to pads is large enough and it looks nice then it is ok.)

@omogenot
Copy link
Author

Regarding you being successful with this patter: Does not proof anything to be honest. I don't know which manufacturing methods you use. Others can not know anything about that. We therefore prefer the use of industry standards (IPC) or manufacturer suggestions (datasheet, application note).

Please link the actual document you used to design the footprint both in the pull request description and inside the footprint description.

Point taken !
Last trial. After that, just cancel my PR.
I'll keep my symbols and foot prints for me in the future, not being adapted to a so strict list of requirements. I understand that things must be controlled, however sometimes, some flexibility isn't bad as well...
Have a nice Sunday, and thanks a lot to both of you for your contant help and support.
Best Regard and Happy new year.

@poeschlr
Copy link
Collaborator

The strict requirements are there such that users can trust them

If you add a footprint from the official lib you would like it to be checked against the full set of rules. Not every user will care about all our rules. (Some might not care about courtyard at all, others might not really care about the exact dimensions on the fab layer, .... But after enough usages every rule will be important to somebody.)

This is just how it is when you want your stuff to be useful to others. There is a bit more work required than using it just for yourself. (You know what your requirements are. Sharing something with others means documenting every parameter. This is what the KLC is there for. If we then randomly decide some rules are not as important then how do users know which footprint follows the rules they care about?)

@omogenot
Copy link
Author

Peace !
I had in the past to throw away 100 PCB/A because at some time the official QFN28 with 1EP footprint was wrong and all the pads were too closed to the exposed pad and the device was in short circuit in the end. As fixing it would have required to unsolder the component, slightly cut all pads around and re-solder the component, this manual operation would have cost too much.
I bite the bullet, thrown all the boards to the trash, made my own footprint. I did not complain to you.
What I meant by this, is that even if you try to be as strict as you can, you can't embrasse all cases.
What was really frustrating was to argue about the length of the bevel needing to be 0.75mm instead of the 0.45mm as it was.
By the way the KLC F5.2 2.b says:

Bevel should be 1mm or 25% of package size (whichever is smaller)

It says should, not must :-D (Just joking !)

Just cancel this PR and we move on. It does not hurt my feelings, I didn't do all this to be famous, but rather to kindly contribute and not just stay as a consumer of your hard work.
I tried, I failed. No problems. I just understand that I'm not good at making drawings (which by the way I knew for a long time ;-) ). Don't worry I'll get over it :-D
Peace again. And Happy new year.

@poeschlr
Copy link
Collaborator

Now with the datasheet present i can do a proper review:

Add the Filter prefix to the footprint name (to fit other footprints in the same lib)

The chamfer line on silk is a bit close to the pad. (There is less than 0.05 mm clearance. I doubt any manufacturer can reliably add this silk line.)

The top fab line is not quite horizontal (left point is out by 0.01mm)

The pad positions are not quite right (At least they do not agree with the datasheet you linked above)
The courtyard clearance is not quite right. (But if you fix the pad position that will change.)

screenshot from 2018-12-23 11-06-11

@poeschlr poeschlr self-assigned this Dec 23, 2018
@poeschlr poeschlr added Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Dec 23, 2018
@poeschlr
Copy link
Collaborator

poeschlr commented Dec 23, 2018

It says should, not must :-D (Just joking !)

Yup we know that. The person writing it was simple too polite. There is an open issue regarding the proper use of a formal language. We could need help with that as well: KiCad/kicad-website#289


Regarding your destroyed board: Do you remember which footprint it was? Is that one still in the lib?

We started an effort to create IPC compliant footprint scripts. We have not yet transferred over all footprints that can be generated with them. (again something where we could need help)
In this endeavor i discovered that the standards where a lot lower in the past (well i already kind of knew that. But i never thought it could have been that bad. Especially EP sizes where really wrong in a lot of cases.)

@omogenot
Copy link
Author

I had to position the pad aligned on the grid to follow KLC as opposed to data sheet info.
I did not have a look at the current QFN28 with 1EP, 6 x 6 mm, just not taking any further risks ;-)
May be the device I used was out of specs as well (page 129):
https://www.semtech.com/uploads/documents/DS_SX1276-7-8-9_W_APP_V5.pdf

For the DCC6C footprint, just forget it. I'm probably the only one using it anyway.
Shall I click on the 'Close and Comment' to withdraw my PR? And do the same to all other related PRs (3D, Symbol, etc.) or are you the one who can do that?

@poeschlr
Copy link
Collaborator

poeschlr commented Dec 23, 2018

Where in the KLC do we mention anything about using grid for pads? (If there is such a rule then it needs to be removed or clarified.)

Regarding your qfn footprint: we only have one 6x6mm qfn footprint in the lib at this point in time. It is one with 4.25mm exposed pad size. Your part would require one with 4.8mm ep size -> this would mean that yours will likely have smaller pads towards inside when compared to the one in the lib. (Meaning with high likely hood you used the wrong footprint or the wrong footprint is assigned to the part if it is indeeed in the lib)

@omogenot
Copy link
Author

I probably mixed up between symbol and footprint requirements. You see too complicated for a simple old man as me.
Never mind, just cancel the whole thing.

@poeschlr
Copy link
Collaborator

SX1276 is not in the lib. However SX1272 is. And that one is assigned to the wrong footprint.
Seems i am right in suspecting that a lot of old symbols using qfn footprints did not particularly care about assigning the correct ep size. (Well it seems i still have a bit of work to do.)

By the way: If you ever find such a problem again then please report it. We can not fix things we do not know about.

@omogenot omogenot closed this Jan 3, 2019
@myfreescalewebpage myfreescalewebpage added the Abandoned Original author has stopped working on the PR label Jan 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Addition Adds new footprint to library Pending changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants