-
Notifications
You must be signed in to change notification settings - Fork 714
Added DCC6C footprint for saw filters (like EPCOS) #1206
Conversation
Travis-Ci says that anchor is not in the middle, but I guess the test fails the test because pad1 is offset by 0.3 mm, which is not a common situation. |
A screenshot of the footprint here in the pull request would help a lot. |
|
Don't you have a cue card (just a one page quick guide summary of list items) of requirements? That would be very helpful to limit the try/fail cycle (and the frustration associated with it I must admit). |
F1 to F9 of KLC. Not sure if there is a summary/shorter version.. |
- Added Pin1 mark on Silk - Moved out CYrd and Fab lines
That's what I meant, having a one page (or even less) summarizing margins, line widths, sizes, etc... not all the details with pictures and so on, just as a reminder and helping doing a very quick checklist per layer. |
For your new screenshot check F5.1.3 "For SMD footprints, silkscreen must be fully visible after boards assembly (no silkscreen allowed under component)" sorry no review of geometry/dimensions by me yet.. |
The courtyard-tolerance is quite tight. It is probably best to use an automated tool for this. I also created my own courtyard-maker, because getting it right by hand is so frustrating: |
Well, definitely the silkscreen will still be visible after assembly. And the courtyard is probably larger enough looking at the resulting 3D view. Using the type of marker you suggested was resulting in getting questions from my factories. They don't like this type of marking and prefer dots or bevels. |
The fab outline should represent the part body size not some framing around the pads. |
The datasheet does not contain a suggested footprint. How did you determine the required pad sizes? |
Google: DCC6C landing pattern ==> I've been using successfully this footprint for production for the last 8 years. |
So, we agree that the Fab layer would cross the pads? |
Fab is not printed onto the pcb so there is no problem with crossing the pads. You really should read the full KLC not just a summary it seems 😁 |
Regarding you being successful with this patter: Does not proof anything to be honest. I don't know which manufacturing methods you use. Others can not know anything about that. We therefore prefer the use of industry standards (IPC) or manufacturer suggestions (datasheet, application note). Please link the actual document you used to design the footprint both in the pull request description and inside the footprint description. @aewallin i think you hang yourself up on some things that are a bit strange. The courtyard layer is the only layer that has any tolerance allowance at all. The fab layer for example must be exact (0 tolerance) same with everything that has to do with pads (copper, mask and paste). The only other layer where we basically do not really care about measurements is the silk layer. (As long as the clearance to pads is large enough and it looks nice then it is ok.) |
Point taken ! |
The strict requirements are there such that users can trust them If you add a footprint from the official lib you would like it to be checked against the full set of rules. Not every user will care about all our rules. (Some might not care about courtyard at all, others might not really care about the exact dimensions on the fab layer, .... But after enough usages every rule will be important to somebody.) This is just how it is when you want your stuff to be useful to others. There is a bit more work required than using it just for yourself. (You know what your requirements are. Sharing something with others means documenting every parameter. This is what the KLC is there for. If we then randomly decide some rules are not as important then how do users know which footprint follows the rules they care about?) |
Peace !
It says should, not must :-D (Just joking !) Just cancel this PR and we move on. It does not hurt my feelings, I didn't do all this to be famous, but rather to kindly contribute and not just stay as a consumer of your hard work. |
Now with the datasheet present i can do a proper review: Add the Filter prefix to the footprint name (to fit other footprints in the same lib) The chamfer line on silk is a bit close to the pad. (There is less than 0.05 mm clearance. I doubt any manufacturer can reliably add this silk line.) The top fab line is not quite horizontal (left point is out by 0.01mm) The pad positions are not quite right (At least they do not agree with the datasheet you linked above) |
Yup we know that. The person writing it was simple too polite. There is an open issue regarding the proper use of a formal language. We could need help with that as well: KiCad/kicad-website#289 Regarding your destroyed board: Do you remember which footprint it was? Is that one still in the lib? We started an effort to create IPC compliant footprint scripts. We have not yet transferred over all footprints that can be generated with them. (again something where we could need help) |
I had to position the pad aligned on the grid to follow KLC as opposed to data sheet info. For the DCC6C footprint, just forget it. I'm probably the only one using it anyway. |
Where in the KLC do we mention anything about using grid for pads? (If there is such a rule then it needs to be removed or clarified.) Regarding your qfn footprint: we only have one 6x6mm qfn footprint in the lib at this point in time. It is one with 4.25mm exposed pad size. Your part would require one with 4.8mm ep size -> this would mean that yours will likely have smaller pads towards inside when compared to the one in the lib. (Meaning with high likely hood you used the wrong footprint or the wrong footprint is assigned to the part if it is indeeed in the lib) |
I probably mixed up between symbol and footprint requirements. You see too complicated for a simple old man as me. |
SX1276 is not in the lib. However SX1272 is. And that one is assigned to the wrong footprint. By the way: If you ever find such a problem again then please report it. We can not fix things we do not know about. |
DCC6C footprint for saw filters
Datasheet : https://en.rf360jv.com/inf/40/ds/ae/B3717.pdf
3D package under KiCad/kicad-packages3D#485
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: