[Doc] Allow llvm.ptr.annotation to specify decorations #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example it allows to translate
@.str.0 = private unnamed_addr addrspace(1) constant [13 x i8]
c"{44:\224\22}\00", section "llvm.metadata"
...
%ptr = alloca i32
%ann_ptr = call ptr @llvm.ptr.annotation.p4.p1(ptr %ptr, ptr
addrspace(1) @.str.0, ptr addrspace(1) @.str.1)
into OpDecorate Alignment 4
Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
vmaksimo
approved these changes
Mar 20, 2024
asudarsa
reviewed
Mar 24, 2024
| In cases when decoration parameter carried by ``llvm.ptr.annotation`` coalesces | ||
| with a value carried by another LLVM attribute, the translator is free to chose | ||
| the value depending on the meaning of the annotation. For example for alignment | ||
| we can chose the biggest alignment specified in LLVM IR: |
There was a problem hiding this comment.
Suggested change
| we can chose the biggest alignment specified in LLVM IR: | |
| we can choose the biggest alignment specified in LLVM IR: |
asudarsa
reviewed
Mar 24, 2024
| ``llvm.ptr.annotation`` LLVM IR intrinsic. Decorations and MemberDecorations | ||
| specified in ``llvm.ptr.annotation`` must be in the second argument and must | ||
| have the format ``{X}`` or ``{X:Y}`` where ``X`` is an integer literal | ||
| representing the SPIR-V decoration identifier and ``Y`` is 1 or more arguments |
There was a problem hiding this comment.
Suggested change
| representing the SPIR-V decoration identifier and ``Y`` is 1 or more arguments | |
| representing the SPIR-V decoration identifier and ``Y`` is a set of 1 or more arguments |
asudarsa
reviewed
Mar 24, 2024
|
|
||
| Class members and instructions returning a pointer can be decorated using the | ||
| ``llvm.ptr.annotation`` LLVM IR intrinsic. Decorations and MemberDecorations | ||
| specified in ``llvm.ptr.annotation`` must be in the second argument and must |
There was a problem hiding this comment.
what does 'must be in the second argument' mean here? Please reword if necessary. Thanks
asudarsa
reviewed
Mar 24, 2024
| @@ -547,6 +547,22 @@ member decorations. | |||
| None of the special requirements imposed from using the reserved names apply to | |||
| using decoration identifiers directly. | |||
|
|
|||
| In cases when decoration parameter carried by ``llvm.ptr.annotation`` coalesces | |||
| with a value carried by another LLVM attribute, the translator is free to chose | |||
There was a problem hiding this comment.
Suggested change
| with a value carried by another LLVM attribute, the translator is free to chose | |
| with a value carried by another LLVM attribute, the translator is free to choose |
asudarsa
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example it allows to translate
into OpDecorate Alignment 4