Integrate cl_ext_image_from_buffer into unified specification #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add version notes for all CL_IMAGE_REQUIREMENTS_* enums. Signed-off-by: Kevin Petit <[email protected]> Change-Id: I7b7b093034121a9215786beff7318b18e7d0c24a
bashbaug
reviewed
Jan 23, 2025
| buffer. | ||
| * {CL_INVALID_IMAGE_SIZE} if the {cl_ext_image_from_buffer_EXT} extension is | ||
| supported and an image is created from a buffer and the buffer passed in | ||
| _image_desc->_mem_object_ is too small to be used as a data store for the |
There was a problem hiding this comment.
Formatting nitpick: I think this should be:
Suggested change
| _image_desc->_mem_object_ is too small to be used as a data store for the | |
| __image_desc__->__mem_object__ is too small to be used as a data store for the |
| @@ -53,7 +53,7 @@ Note that reading and writing 2D image arrays from a kernel with `image_array_si | |||
| ] | |||
|
|
|||
| :fn-image-from-buffer: pass:n[ \ | |||
| To create a 2D image from a buffer object that share the data store between the image and buffer object. \ | |||
| To create an image from a buffer object that share the data store between the image and buffer object. \ | |||
There was a problem hiding this comment.
Optional / editorial: this wasn't changed in this PR, but I don't this sentence is grammatically correct. How about:
Suggested change
| To create an image from a buffer object that share the data store between the image and buffer object. \ | |
| To create an image from a buffer object that shares the data store between the image and buffer object. \ |
Comment on lines
+40
to
+46
| . TODO Test access via read/write/map commands? | ||
|
|
||
| . TODO Test copy to/from buffer? | ||
|
|
||
| . TODO Test fill? | ||
|
|
||
| . TODO Test copy to/from another image? |
There was a problem hiding this comment.
Recording a comment from the January 21st teleconference: do we want to do anything with these TODOs, or are they ok as-is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add version notes for all CL_IMAGE_REQUIREMENTS_* enums.
Change-Id: I7b7b093034121a9215786beff7318b18e7d0c24a