Generate the SPIR-V shaders automatically at build time #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`FindPython3` and `FindPython2` were added in version 3.12. Used by the spirv_new suite. Signed-off-by: Ahmed Hesham <[email protected]>
Signed-off-by: Ahmed Hesham <[email protected]>
Move the SPIR-V assembly helper Python script to the `spirv_asm` subdirectory. Add custom commands and targets to automatically assemble and validate the SPIR-V shaders used by the test. Automatic assembly depends on finding `python3`, `spirv-as` and `spirv-val`. `SPIRV_TOOLS_DIR` can be defined by the user during configuration to provide an override path. Default behaviour assumes that the binaries exist in PATH. Signed-off-by: Ahmed Hesham <[email protected]>
ahesham-arm
force-pushed
the
spirv_new
branch
from
fa63202 to
6a3b0c8
Compare
svenvh
reviewed
Jan 22, 2025
| else() | ||
| message(STATUS "Skipping automatic build of SPIR-V files for spirv_new") | ||
| # Empty custom target | ||
| add_custom_target(spirv_new_shaders) |
There was a problem hiding this comment.
Suggested change
| add_custom_target(spirv_new_shaders) | |
| add_custom_target(spirv_new_binaries) |
There was a problem hiding this comment.
For the spirv_new tests, "shaders" isn't really the correct term as none of them declare the Shader Capability. I would suggest to refer to them as "SPIR-V binaries", which aligns with the --spirv-binaries-path option name.
| return() | ||
| endif() | ||
|
|
||
| set(shader_sources |
There was a problem hiding this comment.
Suggested change
| set(shader_sources | |
| set(spirv_sources |
| vector_times_scalar_half.spvasm32 | ||
| vector_times_scalar_half.spvasm64) | ||
|
|
||
| set(assembled_shaders "") |
There was a problem hiding this comment.
Suggested change
| set(assembled_shaders "") | |
| set(assembled_spirv_binaries "") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom commands and targets to automatically assemble and validate the SPIR-V shaders used by the test.
Automatic assembly depends on finding
python3,spirv-asandspirv-val.SPIRV_TOOLS_DIRcan be defined by the user during configuration to provide an override path. Default behaviour assumes that the binaries exist inPATH.