Fix checkdatabase kw database check task #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-at-orange
force-pushed
the
fix_checkdatabase_KWDatabaseCheckTask
branch
from
646d0ba to
e6917a0
Compare
marcboulle
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
LGTM
Et j'ai vu que tu avais ajouté un commentaire dans l'issue #460: parfait
* Start and stop task progression when aggregate after errors In parallel tasks, when an error occurs, the master send the order to stop slaves. The master may receive messages already sent and then it is possible to launch the aggregation. In that case we have to encapsulate the aggregate process in a progression task in order to pass the assertions * In KWFileIndexerTask::MasterFinalize Move an assertion in the if (bProcessEndedCorrectly) block. It was wrongly triggered in a user interruption/
bruno-at-orange
force-pushed
the
fix_checkdatabase_KWDatabaseCheckTask
branch
from
e6917a0 to
8f58391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 2 bugs from #460:
See the commit for a description