Add KHIOPS_MPI_VERBOSE in khiops_env (UNIXes only) #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-at-orange
force-pushed
the
383-khiops-command-return-error-1-without-any-message
branch
from
5e163af to
7250e88
Compare
bruno-at-orange
force-pushed
the
383-khiops-command-return-error-1-without-any-message
branch
from
7250e88 to
9d82f04
Compare
popescu-v
reviewed
Oct 14, 2024
popescu-v
reviewed
Oct 14, 2024
bruno-at-orange
force-pushed
the
383-khiops-command-return-error-1-without-any-message
branch
from
601d96c to
87358bf
Compare
bruno-at-orange
force-pushed
the
383-khiops-command-return-error-1-without-any-message
branch
from
87358bf to
f80c026
Compare
bruno-at-orange
force-pushed
the
383-khiops-command-return-error-1-without-any-message
branch
from
299afcb to
ca9e3a0
Compare
popescu-v
reviewed
Oct 16, 2024
bruno-at-orange
force-pushed
the
383-khiops-command-return-error-1-without-any-message
branch
2 times, most recently
from
4e5ba4e to
75cc143
Compare
popescu-v
reviewed
Oct 16, 2024
popescu-v
reviewed
Oct 16, 2024
popescu-v
reviewed
Oct 16, 2024
popescu-v
reviewed
Oct 16, 2024
popescu-v
reviewed
Oct 16, 2024
bruno-at-orange
force-pushed
the
383-khiops-command-return-error-1-without-any-message
branch
from
75cc143 to
e579801
Compare
popescu-v
reviewed
Oct 16, 2024
popescu-v
reviewed
Oct 16, 2024
popescu-v
requested changes
Oct 16, 2024
- Add the variable KHIOPS_MPI_VERBOSE to disable the flag "--quiet" in the mpirun command. In khiops_env, its default value is true and the mpirun is run without --quiet. if its value is different from 'true', '--quiet' is added to the command line. - On the contrary, KHIOPS_MPI_VERBOSE default value is false in the script 'khiops': we don't want to see MPI messages when running khiops in standalone. - some variables are mandatory to run MPI correctly (like OMPI_MCA_btl_vader_single_copy_mechanism), these variables are displayed when running `khiops-env --env`. In that way, all variables needed to run Khiops are avalaible for khiops' wrappers. - Add KHIOPS_MPI_VERBOSE=true to the tests on CI: test-khiops-on-iris and test-khiops-install in order to check that there is no MPI error
The environment modules systematically: - undloads current mpi module - loads the desired mpi module In that way we are sure to launch the appropriate mpiexec.
bruno-at-orange
force-pushed
the
383-khiops-command-return-error-1-without-any-message
branch
from
e579801 to
e2b0b70
Compare
bruno-at-orange
deleted the
383-khiops-command-return-error-1-without-any-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the variable KHIOPS_MPI_VERBOSE to disable the flag "--quiet" in the mpirun command. Its default value in
khiops_envis true and the mpirun is verbose. if its value is different from 'true', '--quiet' is added to the command line.Close #383
Close #310