fix rare crash when unfavoriting an item twice (cataclysmbnteam#2180)

KheirFerrum · Nov 26, 2022 · 82b62d6 · 82b62d6
1 parent a4bab60
commit 82b62d6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/inventory_ui.cpp b/src/inventory_ui.cpp
@@ -699,8 +699,10 @@ void inventory_column::on_input( const inventory_input &input )
     } else if( input.action == "END" ) {
         select( entries.size() - 1, scroll_direction::BACKWARD );
     } else if( input.action == "TOGGLE_FAVORITE" ) {
-        const item_location &loc = get_selected().any_item();
-        set_stack_favorite( loc, !loc->is_favorite );
+        if( !get_selected().locations.empty() ) {
+            const item_location &loc = get_selected().any_item();
+            set_stack_favorite( loc, !loc->is_favorite );
+        }
     }
 }