Fix: Open unlimited polygon does not restrict crossing sides. #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (ceb9775) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1896If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1896 |
|
Size Change: +175 B (+0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
catandthemachines
requested review from
benchristel,
nishasy and
anakaren-rojas
nishasy
approved these changes
Nov 22, 2024
packages/perseus/src/widgets/interactive-graphs/reducer/interactive-graph-reducer.ts
Outdated
Show resolved
Hide resolved
benchristel
reviewed
Nov 22, 2024
There was a problem hiding this comment.
What happens when closing the polygon is what causes the sides to cross? Can you then untangle the points using the keyboard, or are they stuck?
I think we might need some logic like "if the polygon's sides currently cross, don't reject a move that results in the sides still crossing."
There was a problem hiding this comment.
The changes to this file seem unrelated to the rest of the PR. Are they supposed to be included?
benchristel
approved these changes
Nov 22, 2024
Merged
nishasy
added a commit
that referenced
this pull request
Nov 26, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/[email protected] ### Patch Changes - [#1896](#1896) [`56fd44806`](56fd448) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing intersecting polygon sides issues for unlimited sided polygon. - [#1894](#1894) [`01edfb8be`](01edfb8) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Add comment about making translation tickets - [#1875](#1875) [`28cae9d2a`](28cae9d) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Labels] Count lone unescaped \\$ as regular dollar signs in TeX ## @khanacademy/[email protected] ### Patch Changes - [#1874](#1874) [`42d25c2d2`](42d25c2) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Figure Aria] Fix \\$ edge cases for spoken math aria labels - [#1912](#1912) [`44e78a95d`](44e78a9) Thanks [@nishasy](https://github.com/nishasy)! - [Interactive Graph Editor] Stop cursor jumps in number input fields - [#1875](#1875) [`28cae9d2a`](28cae9d) Thanks [@nishasy](https://github.com/nishasy)! - [Locked Labels] Count lone unescaped \\$ as regular dollar signs in TeX - Updated dependencies \[[`56fd44806`](56fd448), [`01edfb8be`](01edfb8), [`28cae9d2a`](28cae9d)]: - @khanacademy/[email protected]
benchristel
pushed a commit
that referenced
this pull request
Nov 26, 2024
## Summary: For keyboard users if they're drawing a polygon and it places a point at 0,0. There are cases where it could cross the sides of the polygon they are actively creating and cause the polygon to break. Mouse uses can get around this a bit. But it's not idea. This fix checks whether the polygon type allows intersecting sides and disables the rejection logic. This PR also includes improvements to: - Screen readers announcing instructions to enable graph (was not reading out before). - Disabled buttons are not tabbable now. Issue: LEMS-2618 ## Test plan: Go to /?path=/story/perseus-widgets-interactive-graph--unlimited-polygon-with-mafs in Storybook. Use your keyboard to add points. Move a few points in a way that a new point would cause the sides to intersect. Add a new point and make sure you can still move points on the polygon. Author: catandthemachines Reviewers: catandthemachines, nishasy, benchristel, anakaren-rojas Required Reviewers: Approved By: nishasy, benchristel Checks: ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x), ✅ gerald Pull Request URL: #1896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For keyboard users if they're drawing a polygon and it places a point at 0,0. There are cases where it could cross the sides of the polygon they are actively creating and cause the polygon to break. Mouse uses can get around this a bit. But it's not idea. This fix checks whether the polygon type allows intersecting sides and disables the rejection logic.
This PR also includes improvements to:
Issue: LEMS-2618
Test plan:
Go to /?path=/story/perseus-widgets-interactive-graph--unlimited-polygon-with-mafs in Storybook.
Use your keyboard to add points.
Move a few points in a way that a new point would cause the sides to intersect.
Add a new point and make sure you can still move points on the polygon.