Merge pull request #25 from Keyfactor/urlencodepwd

Urlencodepwd
Keyfactor · Jul 25, 2024 · e362656 · e362656
2 parents a826398 + 9eb4e7e
commit e362656
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+2.2.1
+* Fixed URL Encoding on Palo Username and Pwd that caused invalid credentials error
+
 2.2.0
 * Removed support for binding cert to new binding location, can only update certs that are previously bound
 * Support for replacing certs on all binding locations both Panorama and Firewalls as long as it was there before

diff --git a/PaloAlto/Client/PaloAltoClient.cs b/PaloAlto/Client/PaloAltoClient.cs
@@ -34,8 +34,8 @@ public class PaloAltoClient
         public PaloAltoClient(string url, string userName, string password)
         {
             _logger = LogHandler.GetClassLogger<PaloAltoClient>();
-            ServerUserName = userName;
-            ServerPassword = password;
+            ServerUserName = Uri.EscapeDataString(userName);
+            ServerPassword = Uri.EscapeDataString(password);
             var httpClientHandler = new HttpClientHandler
             {
                 ServerCertificateCustomValidationCallback = (message, cert, chain, sslPolicyErrors) => true