46551 update store types #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated store-types schema to an array of store-types
Add store_types workflow to generate kfutil store_types.json
|
@rcpokorny Hey the cert store types stuff in the manifest still doesn't match the readme... The question marks were removed on some of the display names, and other displayname where changed as well. Please verify that all the parameters and entry parameters match what is in the readme. |
Completed second pass of settings to match that in Read Me.
Updated json file with correct output using latest version of KFUTIL.
joynerar
reviewed
Jun 28, 2023
integration-manifest.json
Outdated
Comment on lines
297
to
322
| "StorePathValue": "[\"My\",\"WebHosting\"]", | ||
| "StorePathType": "", | ||
| "StorePathValue": "", |
There was a problem hiding this comment.
Not sure if you're still working on this @rcpokorny, but for IISU we're going to want to restrict the store paths to My and WebHosting via a multiple-choice type.
|
Thanks Adam - I am still testing the KFUtil application. It appears that some properties are being missed. I will notify Sean that the property has been removed from the json.
From: Adam Joyner ***@***.***>
Sent: Wednesday, June 28, 2023 10:49 AM
To: Keyfactor/iis-orchestrator ***@***.***>
Cc: Bob Pokorny ***@***.***>; Mention ***@***.***>
Subject: Re: [Keyfactor/iis-orchestrator] 46551 update store types (PR #79)
CAUTION: External Sender - Be cautious when clicking links or opening attachments. Please email ***@***.******@***.***> with any questions.
@joynerar commented on this pull request.
________________________________
In integration-manifest.json<#79 (comment)>:
- "StorePathValue": "[\"My\",\"WebHosting\"]",
+ "StorePathType": "",
+ "StorePathValue": "",
Not sure if you're still working on this @rcpokorny<https://github.com/rcpokorny>, but for IISU we're going to want to restrict the store paths to My and WebHosting via a multiple-choice type.
-
Reply to this email directly, view it on GitHub<#79 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANII75LDIII4YWKUIXP353LXNRG47ANCNFSM6AAAAAAZWD6AYY>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Updated JSON after additional fix to KFUtil
|
@RexWheeler @rcpokorny @fiddlermikey - What is the status of this PR? I have another coming into the dev branch shortly for SQL Bindings. |
|
This PR has all the updated changes to the integration manifest to match that of the updated read me.
I was working with @sean ***@***.***> on the KFUtil, making sure the settings were being created correctly. Sean was having problems with KFUtil and said he needed to do some work. My guess is this fell through the cracks.
I copied Sean on this email, let's see if we can get an update from him. If KFUtil is secondary, we can merge this PR and move forward.
From: Brian Hill ***@***.***>
Sent: Thursday, August 10, 2023 9:05 AM
To: Keyfactor/iis-orchestrator ***@***.***>
Cc: Bob Pokorny ***@***.***>; Mention ***@***.***>
Subject: Re: [Keyfactor/iis-orchestrator] 46551 update store types (PR #79)
CAUTION: External Sender - Be cautious when clicking links or opening attachments. Please email ***@***.******@***.***> with any questions.
@RexWheeler<https://github.com/RexWheeler> @rcpokorny<https://github.com/rcpokorny> @fiddlermikey<https://github.com/fiddlermikey> - What is the status of this PR? I have another coming into the dev branch shortly for SQL Bindings.
-
Reply to this email directly, view it on GitHub<#79 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANII75PQFLEALPVA2NLD52LXUTTAPANCNFSM6AAAAAAZWD6AYY>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the integration-manifest json file so the settings would match the values in the Read Me documentation.