Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MadeMisstakeIgnore #193

Closed
wants to merge 38 commits into from
Closed

MadeMisstakeIgnore #193

wants to merge 38 commits into from

Conversation

Gajjek
Copy link

@Gajjek Gajjek commented Oct 23, 2023

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

galican and others added 30 commits April 12, 2023 10:27
@galican
Add Keychron Q1 Version 2
523989b
@galican
more refactoring common code
fd8ec24
@galican
Shift these "y" positions by +.25
37d1906
@galican
Removed encoder map definition from rules.mk
95317d0
@KeychronMacro @drashna
Update keyboards/keychron/q1v2/readme.md
b27651b 
Co-authored-by: Drashna Jaelre <[email protected]>
@KeychronMacro @fauxpark
Update keyboards/keychron/q1v2/config.h
981ae63 
Co-authored-by: Ryan <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/config.h
e073fcf 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/ansi/info.json
26814bd 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/info.json
0be23bc 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/ansi/info.json
46d3a94 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/ansi/rules.mk
ce85ef3 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/info.json
7456c89 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/ansi/keymaps/default/keymap.c
7e45d98 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/ansi/keymaps/keychron/keymap.c
0cf9c5e 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/ansi/keymaps/via/keymap.c
5ea5024 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro
Move common features into q1v2/info.json
0fa0f5e
@KeychronMacro @drashna
Update keyboards/keychron/q1v2/ansi/keymaps/default/keymap.c
e60c099 
Co-authored-by: Drashna Jaelre <[email protected]>
@KeychronMacro
Move encoder map definition to keymap level
1aa7ad5
@KeychronMacro
Merge branch 'keychron-q1v2' of https://github.com/Keychron/qmk_firmware
3d088b4 
 into keychron-q1v2
@KeychronMacro
Removed q1v2/rule.mk
535005e
@adophoxia
Move LAYOUT options back into seperate variants
86c387b
@KeychronMacro
Merge pull request Keychron#127 from adophoxia/keychron-q1v2-suggested
9abbc75 
Move `LAYOUT` options back into seperate variants
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/ansi_encoder/keymaps/default/keymap.c
b6aec6c 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/jis_encoder/keymaps/default/keymap.c
9a6e740 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/iso_encoder/keymaps/default/keymap.c
26fff56 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/ansi_encoder/keymaps/via/keymap.c
03446c7 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/ansi_encoder/keymaps/keychron/keymap.c
2588c08 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/jis_encoder/keymaps/keychron/keymap.c
dfe1d5c 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/jis_encoder/keymaps/via/keymap.c
90c3f66 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/iso_encoder/keymaps/keychron/keymap.c
f2e63ac 
Co-authored-by: adophoxia <[email protected]>
KeychronMacro and others added 8 commits May 29, 2023 11:41
@KeychronMacro @adophoxia
Update keyboards/keychron/q1v2/iso_encoder/keymaps/via/keymap.c
d731b4c 
Co-authored-by: adophoxia <[email protected]>
@KeychronMacro @fauxpark
Update keyboards/keychron/q1v2/ansi/rules.mk
4b99b37 
Co-authored-by: Ryan <[email protected]>
@KeychronMacro @fauxpark
Update keyboards/keychron/q1v2/jis/rules.mk
50f8060 
Co-authored-by: Ryan <[email protected]>
@KeychronMacro @fauxpark
Update keyboards/keychron/q1v2/iso_encoder/rules.mk
18a6604 
Co-authored-by: Ryan <[email protected]>
@KeychronMacro @fauxpark
Update keyboards/keychron/q1v2/ansi_encoder/rules.mk
44b2b69 
Co-authored-by: Ryan <[email protected]>
@KeychronMacro @fauxpark
Update keyboards/keychron/q1v2/jis_encoder/rules.mk
13c9b1e 
Co-authored-by: Ryan <[email protected]>
@KeychronMacro @fauxpark
Update keyboards/keychron/q1v2/iso/rules.mk
843a0da 
Co-authored-by: Ryan <[email protected]>
@Gajjek
Can collect 1 password and blink the password sequence in the rgb.
e71677d
@Gajjek Gajjek closed this Oct 23, 2023
@Gajjek Gajjek deleted the keychron-q1v2 branch October 23, 2023 09:31
@Gajjek Gajjek restored the keychron-q1v2 branch October 23, 2023 09:31
@Gajjek Gajjek deleted the keychron-q1v2 branch October 23, 2023 09:31
@Gajjek Gajjek restored the keychron-q1v2 branch October 23, 2023 09:31
@Gajjek Gajjek changed the title Keychron q1v2 Misstake Oct 23, 2023
@Gajjek Gajjek changed the title Misstake MadeMisstake Oct 23, 2023
@Gajjek Gajjek changed the title MadeMisstake MadeMisstakeIgnore Oct 23, 2023
@Gajjek Gajjek reopened this Oct 23, 2023
@Gajjek Gajjek closed this Oct 23, 2023
@Gajjek
Copy link
Author

Gajjek commented Oct 23, 2023

Just tried to push to my fork, seems like i may have fucked something up, but not sure. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
keyboard keymap via
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gajjek @galican @KeychronMacro @adophoxia