Replace FunctionFieldReferenceOperator with Calcite DOT operator #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGe00
changed the title
KevinGe00
changed the title
…former (linkedin#512) * fix redundant transforms/casts * spotless * fix fuzzyunionsqlrewriter incorrect struct type when building structs * remove unused * spotless * spotless
* add precision for int and bigint for hive type system * use static final variables for precisions * spotless check * fix converting type to typespec bug * add UT * add tinyint and smallint precisions * spotless * spotless * spotless * new UTs * add tableInt to rel to trino tests * spotless * remove redundant test
* fix single uniontypes in Coral * remove SingleUnionFieldReferenceTransformer * remove field reference fix to put in separate PR * spotless * update comments * fix comment + add single uniontype test for RelDataTypeToHiveTypeStringConverter * spotless * improve Javadoc for ExtractUnionFunctionTransformer * use html brackets in javadoc
… conversion (linkedin#521) * temp * temp * use coralsqldialect in trino reltosql * Import class not member
…ence on UDF calls (linkedin#510) * fix field reference bug in coral schema * bring back override tag * address nits
KevinGe00
force-pushed
the
migrate-func-field-ref
branch
from
8a4f50c to
7602c2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
We can get rid of
FunctionFieldReferenceOperatorentirely and replace it with Calcite's defaultSqlDotOperator. HistoricallyFunctionFieldReferenceOperatorwas introduced because "Calcite DOT operator by default does not work for referencing fields from struct return types of functions." However, that's no longer the case, thus renderingFunctionFieldReferenceOperatorunneeded. If we can get rid ofFunctionFieldReferenceOperator, we also no longer need to migrate it (as part of Coral IR upgrades).How was this patch tested?
Only regression I'm seeing is a cosmetic one that is actually desirable. Unnecessary parentheses introduced because FunctionFieldReferenceOperator is not a native Calcite operator go away: