Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes logic check both connection sandbox mode and request params for the dev flag #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZloeSabo
Copy link
Contributor

Description

This change allows passing this flag either as a request parameter or specifying the sandbox mode for a connection.

The existing logic was a bit confusing because IRequest allows to specify the dev flag, but the Connection wasn't using it.

Steps to Test or Reproduce

I've checked that both of those send request with the correct dev flag:

            var connection = Connection.Create("your_key", "your_secret");
            var client = new Client(connection);
            var response = client.OptimizeWait("./example.jpg",
                new OptimizeUploadWaitRequest()
                {
                    Lossy = true,
                    Dev = true
                });
            var connection = Connection.Create("your_key", "your_secret", true);
            var client = new Client(connection);
            var response = client.OptimizeWait("./example.jpg",
                new OptimizeUploadWaitRequest()
                {
                    Lossy = true
                });

Todos

  • Tests succeeded
  • Documentation updated
  • Nuget release information & Build version updated (build.fsx)

ZloeSabo added 2 commits June 29, 2020 13:25
… the dev flag

Previously logic was only considering the client sandbox mode.

This change allows passing this flag either as a request parameter or
specifying the sandbox mode for a connection.
@ZloeSabo ZloeSabo force-pushed the bugfix/consider-dev-in-request branch from 9def449 to c353f8f Compare June 29, 2020 11:25
@Kevin-Bronsdijk
Copy link
Owner

Sorry for the delay in my response. I haven't worked on the Kraken client for a while and therefore not able to see the issue in the previous PR. In order to make sure all is working, I will create a new Kraken account today and rerun the integration tests in order to verify the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants