Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: #12 - Make consent logging configurable #22

Merged

Conversation

heoehmke
Copy link

Closes #12

Copy link
Contributor

@Nikdro Nikdro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you for your contribution, looking good so far!

I'm currently not very sure, if we should disable the logging by default. If we do, we should release a new Version 3.0 (which wouldn't be a problem). But we started with tracking here, because having the logs available was an requirement of a customer according to the DSGVO.

We will investigate that next week and would then release Version 3 with your changes or turning the option into an opt-out (true by default).

What's your personal opinion about that? Please let us know 🙂

@heoehmke
Copy link
Author

I am not fully aware of the legal situation, if it's mandatory to log users consents according GDPR I personally think it's better to leave it on by default in order to have a GDPR compliant ready-to-run package. Apart from that I could imagine many users want logging turned on for statistical reasons, especially since you planned to visualize the stats in #11 and to get an idea how meaningful Google Analytics stats are. But I think in case of leaving it on by default the Readme should make it clear more noticeable, maybe at the top of the Configuration section, so users are aware of it and don't wonder when their database suddenly blows up.

@Nikdro
Copy link
Contributor

Nikdro commented Sep 28, 2020

After some research, we unfortunately could not find a consistent statement about that topic. According to some statements it is urgently necessary to save the decision on the server. Other sources advise against it because of GDPR-violations. Also the lawyer of our customer, who requested logging, wasn't even sure about it.

Since we want to leave the decision to everyone individually, I gladly accept your PR. But I will make a version 3.0 out of it so that we don't get breaking-changes in small version jumps. The 3.0 branch will then be provided with additional logging features in the future.

Thank you very much @heoehmke!

@Nikdro Nikdro merged commit cca9abf into KaufmannDigital:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make logging configurable
2 participants