Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37923 - Set HTTP proxy as default after creating #11183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #37923 - Set HTTP proxy as default after creating #11183

wants to merge 1 commit into from
+62 −0

Conversation

stejskalleos
Copy link
Contributor

@stejskalleos stejskalleos commented Oct 17, 2024 •
edited
Loading

What are the changes introduced in this pull request?

An option for making HTTP proxy the default content proxy after creation.

Considerations taken when implementing this change?

https://issues.redhat.com/browse/SAT-28860

What are the testing steps for this pull request?

@chris1984
Copy link
Member

@stejskalleos is this ready to be pulled out of draft state?

@stejskalleos
Copy link
Contributor Author

@chris1984 not yet, I need to update Jira tickets first and check if I haven't forgot something

@stejskalleos stejskalleos mentioned this pull request Nov 11, 2024
Merged
@stejskalleos
Copy link
Contributor Author

@chris1984 @ShimShtein ready for review, together with theforeman/foreman#10372

@stejskalleos stejskalleos marked this pull request as ready for review November 11, 2024 09:46
@stejskalleos
Copy link
Contributor Author

@ofedoren updated
cc @jeremylenz @ianballou Katello folks

ianballou
ianballou reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well! Just one comment about the text.

app/views/overrides/http_proxies/_update_setting_input.html.erb Outdated Show resolved Hide resolved
Gauravtalreja1
Gauravtalreja1 reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works well, providing some feedback for improvement

app/controllers/katello/concerns/api/v2/http_proxies_controller_extensions.rb Outdated Show resolved Hide resolved
app/views/overrides/http_proxies/_update_setting_input.html.erb
Comment on lines +11 to +13
id: 'http_proxy_default_content' %>
Set this proxy as the default for content, updating the 'Default HTTP Proxy' setting.
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we create a http proxy with default_content_proxy set to true with UI, it gets created successfully and setting is updated, but when we click on created proxy on edit page we don't see the value set for default_content_proxy, so I feel it would be better to include it on edit page too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, If we decide to add it to the edit page, will it be possible to change it or will it remain grayed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tied to a Setting, so if it were included on the edit page it would have to be disabled. It would just be an indicator of whether this current HTTP proxy is set as the default.

This was referenced Nov 19, 2024
Open
Open
@Lennonka
Copy link
Contributor

I agree with the suggestions by Ian and Gaurav above.

@stejskalleos
Copy link
Contributor Author

@ianballou @Gauravtalreja1 texts updated

ianballou
ianballou approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ianballou
Copy link
Member

Are other parties all good with the changes? @Lennonka and @Gauravtalreja1 ?

@ShimShtein
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofedoren ofedoren ofedoren left review comments

@jeremylenz jeremylenz jeremylenz left review comments

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 left review comments

@ShimShtein ShimShtein ShimShtein left review comments

@Lennonka Lennonka Lennonka approved these changes

@ianballou ianballou ianballou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@stejskalleos @chris1984 @Lennonka @ianballou @ShimShtein @Gauravtalreja1 @jeremylenz @ofedoren