Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] 4.13.1 #11081

Merged
merged 6 commits into from
Jul 23, 2024
Merged

[CP] 4.13.1 #11081

merged 6 commits into from
Jul 23, 2024

Conversation

parthaa
Copy link
Contributor

@parthaa parthaa commented Jul 18, 2024 •
edited
Loading

No description provided.

ianballou and others added 3 commits July 18, 2024 15:10
@ianballou @parthaa
Fixes #37609 - Migrate sha1 repos only at the next edit/sync time
4054e78 
(cherry picked from commit 2072d3f)
@sjha4 @parthaa
Drop anemone and use Spidr for Repo discovery (Katello#10947)
4709277 
* Fixes #37159 - Drop anemone and use Spidr for repo discovery

* Refs #37159 - Improve discovery performance and add gem dependency

* Refs #37159 - Refactor content specific discoveries

* Refs #37159 - Refactor content registration to record discovery class

(cherry picked from commit e55b8d1)
@jeremylenz @parthaa
Fixes #37618 - Update host content view environments from sub-man (Ka…
17ee105 
…tello#11060)

(cherry picked from commit 799e099)
chris1984
chris1984 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APJ

@jeremylenz
Copy link
Member

jeremylenz commented Jul 18, 2024 •
edited
Loading

looks like 'React Tests' still uses the old (broken) GH workflow. But there are no JS changes in these commits AFAIK, so it's fine to ignore that check.

@Odilhao
Copy link

Odilhao commented Jul 23, 2024

@ianballou @parthaa can we include this #11057? At some point we will need to cherrypick the new pulp-rpm into 3.49 branch

@ianballou
Copy link
Member

@Odilhao yeah we should also include that bindings bump commit here.

@ianballou
Copy link
Member

@parthaa let me know if CPing in that pulp-rpm update commit causes VCR errors, if it does we may need to do some re-recording.

@parthaa
Copy link
Contributor Author

parthaa commented Jul 23, 2024

@parthaa let me know if CPing in that pulp-rpm update commit causes VCR errors, if it does we may need to do some re-recording.

CP worked fine. make sure https://github.com/Katello/katello/pull/11081/files#diff-21cb8426e694930953a1fb66d2f1e4c0c4021bcadd760d9582423094a4dcaace looks correct.

@parthaa parthaa merged commit 5bc0500 into Katello:KATELLO-4.13 Jul 23, 2024
18 of 22 checks passed
@parthaa parthaa deleted the 4.13.1 branch July 23, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianballou ianballou ianballou approved these changes

@chris1984 chris1984 chris1984 approved these changes

Assignees
No one assigned
Labels
Needs re-review Packaging Change Stable branch Waiting on contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@parthaa @jeremylenz @Odilhao @ianballou @chris1984 @sjha4